Skip to content

Add a way to add a variable to a dictionary using a complete specification#471

Merged
tramora merged 1 commit intodevfrom
401-add-variable-to-dictionary-in-one-step
Sep 17, 2025
Merged

Add a way to add a variable to a dictionary using a complete specification#471
tramora merged 1 commit intodevfrom
401-add-variable-to-dictionary-in-one-step

Conversation

@tramora
Copy link
Copy Markdown
Collaborator

@tramora tramora commented Sep 9, 2025

Fixes #401


TODO Before Asking for a Review

  • Rebase your branch to the latest version of dev (or main for release PRs)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@tramora tramora force-pushed the 401-add-variable-to-dictionary-in-one-step branch 2 times, most recently from 2e7cdc5 to 3291562 Compare September 11, 2025 10:09
Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments.

@tramora tramora force-pushed the 401-add-variable-to-dictionary-in-one-step branch 2 times, most recently from 6eeaba4 to 8e6db1b Compare September 11, 2025 17:27
@tramora tramora force-pushed the 401-add-variable-to-dictionary-in-one-step branch from 8e6db1b to 0110049 Compare September 11, 2025 17:35
@tramora tramora force-pushed the 401-add-variable-to-dictionary-in-one-step branch from 0110049 to a4219d5 Compare September 12, 2025 10:06
@tramora tramora force-pushed the 401-add-variable-to-dictionary-in-one-step branch 2 times, most recently from 77b8704 to ea6ecf5 Compare September 16, 2025 13:56
@tramora tramora requested a review from popescu-v September 16, 2025 14:04
@tramora tramora force-pushed the 401-add-variable-to-dictionary-in-one-step branch 2 times, most recently from 45676ba to 7a0039e Compare September 16, 2025 15:44
@tramora tramora force-pushed the 401-add-variable-to-dictionary-in-one-step branch from 7a0039e to 3c31266 Compare September 16, 2025 15:45
@tramora tramora requested a review from popescu-v September 16, 2025 15:46
Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some pending comments.

@tramora tramora force-pushed the 401-add-variable-to-dictionary-in-one-step branch from 3c31266 to 9ad4e38 Compare September 16, 2025 17:42
@tramora tramora requested a review from popescu-v September 16, 2025 17:44
@tramora tramora force-pushed the 401-add-variable-to-dictionary-in-one-step branch 2 times, most recently from e83511c to 81e5526 Compare September 16, 2025 19:13
Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

@tramora tramora force-pushed the 401-add-variable-to-dictionary-in-one-step branch from 81e5526 to 979b38a Compare September 17, 2025 14:56
@tramora tramora force-pushed the 401-add-variable-to-dictionary-in-one-step branch from 979b38a to 60f3bf9 Compare September 17, 2025 15:31
Copy link
Copy Markdown
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can be merged after rebase on dev.

@tramora tramora force-pushed the 401-add-variable-to-dictionary-in-one-step branch from 60f3bf9 to f9fdfcc Compare September 17, 2025 16:59
@tramora tramora merged commit 024a561 into dev Sep 17, 2025
19 checks passed
@tramora tramora deleted the 401-add-variable-to-dictionary-in-one-step branch September 17, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add API to Add Dictionary Variables

3 participants