Simplify the Rule API#481
Merged
Merged
Conversation
Closed
popescu-v
force-pushed
the
479-improve-khrule-support
branch
from
9a43909 to
e193013
Compare
folmos-at-orange
requested changes
Sep 30, 2025
tramora
reviewed
Sep 30, 2025
tramora
reviewed
Sep 30, 2025
tramora
reviewed
Sep 30, 2025
Only attach rules to variables (and variable blocks) as strings. Also add notes to the `Rule` object docstring. TODO: Add some rule serialization examples. related_to #479
Indeed, parenthesized no-operand rule specification can only be done via the `verbatim` parameter.
- add rule creation examples - add details to the docstring of the `Rule.write` method.
popescu-v
force-pushed
the
479-improve-khrule-support
branch
from
e193013 to
1dd711b
Compare
folmos-at-orange
approved these changes
Sep 30, 2025
folmos-at-orange
left a comment
folmos-at-orange
left a comment
Member
There was a problem hiding this comment.
Maybe mention somewhere in the Rule class docstring that it is a "rule factory".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only attach rules to variables (and variable blocks) as strings.
Also add notes to the
Ruleobjectcloses #479
TODO Before Asking for a Review
dev(ormainfor release PRs)[ ] When adding a public feature/fix: Update theNot needed: it's just a simplification of an already-announced feature.Unreleasedsection ofCHANGELOG.md(no date)index.html