Fix a border case for local fs copy from local#504
Merged
Conversation
1ec4725 to
72461cb
Compare
72461cb to
46c46c3
Compare
popescu-v
reviewed
Nov 14, 2025
e423b7c to
2b2fda4
Compare
popescu-v
reviewed
Nov 18, 2025
popescu-v
requested changes
Nov 18, 2025
Collaborator
popescu-v
left a comment
There was a problem hiding this comment.
See the remaining comment.
1900aff to
ee63b91
Compare
popescu-v
reviewed
Nov 20, 2025
tests/test_core.py
Outdated
Comment on lines
+3218
to
+3220
| with contextlib.suppress(FileNotFoundError): | ||
| os.remove(target_file_name1) | ||
| os.remove(target_file_name2) |
Collaborator
There was a problem hiding this comment.
IMHO, we could also use pathlib.Path(target_file_name1).unlink(missing_ok=True), which seems simpler and more explicit to me.
popescu-v
approved these changes
Nov 20, 2025
Collaborator
popescu-v
left a comment
There was a problem hiding this comment.
LGTM, but a further simplification can be made in the tests (see comment).
… path is relative Without this fix the library would try and fail to create a parent directory named ''
ee63b91 to
ac401a2
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a border case in the
LocalFileSystem.copy_from_localwhere a relative path is given for the target file.The library would try and fail to create a parent directory named ''
TODO Before Asking for a Review
dev(ormainfor release PRs)Unreleasedsection ofCHANGELOG.md(no date)index.html