Ensure HOME is always set when running khiops core with OpenMPI 5+ by tramora · Pull Request #507 · KhiopsML/khiops-python

tramora · 2025-11-19T18:49:42Z

A specific environment is created when running khiops core. In this environment HOME is set using KHIOPS_MPI_HOME if it exists

Fixes #506

TODO Before Asking for a Review

Rebase your branch to the latest version of dev (or main for release PRs)
Make sure all CI workflows are green
When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
Self-Review: Review "Files Changed" tab and fix any problems you find
API Docs (only if there are changes in docstrings, rst files or samples):
- Check the docs build without warning: see the log of the API Docs workflow
- Check that your changes render well in HTML: download the API Docs artifact and open index.html
- If there are any problems it is faster to iterate by building locally the API Docs

khiops/core/internals/runner.py

tests/test_khiops_integrations.py

popescu-v

Propagate custom HOME to the Khiops binary process only (see the comment in the review).

To really test for this change, add new khiopspydev-debian13 Docker image based on the khiopsdev-debian13 Docker image and use it the container matrix in the check-khiops-integration-on-linux job of the tests.yml workflow. Thus, we make sure to really test on OpenMPI 5.

.github/workflows/pip.yml

.github/workflows/tests.yml

packaging/docker/khiopspydev/Dockerfile.debian

packaging/docker/khiopspydev/Dockerfile.rocky

packaging/docker/khiopspydev/Dockerfile.ubuntu

khiops/core/internals/runner.py

popescu-v

There are a few pending comments, the most important of which is to revert to using conday-forge/label/rc:: instead of khiops-dev, which should not be needed.

popescu-v · 2025-12-03T17:30:48Z

khiops/core/internals/runner.py

+    with the global one.
+    """
+    khiops_env = os.environ.copy()
+    # Ensure HOME is always set for OpenMPI 5+


Insert empty line before, as this is a paragraph.

popescu-v

LGTM, with a minor comment.

- A specific environment is created when running khiops core. In this environment HOME is set using KHIOPS_MPI_HOME if it exists

- Create and use a new khiopspydev debian13 image with OpenMPI 5 - Set OpenMPI 5+ specific env variables for oversubscribing

In conda environments new incompatibility issues appear

- escape Conda channel label - use double equals sign in conda package version specification - drop conda-forge channel specification: conda uses conda-forge by default, because it is installed with miniforge.

tramora requested review from folmos-at-orange and popescu-v and removed request for folmos-at-orange November 19, 2025 18:49

tramora force-pushed the 506-fix-home-for-openmpi5 branch 3 times, most recently from 77b659b to 5eb7cc0 Compare November 20, 2025 12:53

tramora changed the title ~~Ensure HOME env variable is always set (mandatory for OpenMPI 5+)~~ Ensure HOME env variable is corrected for OpenMPI 5+ Nov 20, 2025

popescu-v reviewed Nov 20, 2025

View reviewed changes

khiops/core/internals/runner.py Outdated Show resolved Hide resolved

popescu-v reviewed Nov 20, 2025

View reviewed changes

tests/test_khiops_integrations.py Show resolved Hide resolved

popescu-v requested changes Nov 20, 2025

View reviewed changes

tramora changed the title ~~Ensure HOME env variable is corrected for OpenMPI 5+~~ Ensure HOME is always set when running khiops core with OpenMPI 5+ Nov 21, 2025

tramora force-pushed the 506-fix-home-for-openmpi5 branch 18 times, most recently from 92ae579 to fcc4b5b Compare November 26, 2025 15:57