refactor: clean up code formatting and improve readability in demo and backend tests

Author: ElouenGinat

sandbox/khisto_demo.ipynb

@@ -453,7 +453,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 13,
+   "execution_count": null,
    "id": "1190f8aa",
    "metadata": {},
    "outputs": [
@@ -484,12 +484,12 @@
     "print(\"\\nGranularity levels:\")\n",
     "for r in results:\n",
     "    marker = \" ← BEST\" if r.is_best else \"\"\n",
-    "    print(f\"  Granularity {r.granularity}: {len(r.frequency)} bins{marker}\")"
+    "    print(f\"  Granularity {r.granularity}: {len(r.frequencies)} bins{marker}\")"
    ]
   },
   {
    "cell_type": "code",
-   "execution_count": 14,
+   "execution_count": null,
    "id": "bf2ba150",
    "metadata": {},
    "outputs": [
@@ -512,8 +512,8 @@
     "\n",
     "for i, r in enumerate(results[:n_levels]):\n",
     "    ax = axes[i]\n",
-    "    ax.stairs(r.frequency, r.bin_edges, fill=True, alpha=0.7)\n",
-    "    title = f\"Granularity {r.granularity} ({len(r.frequency)} bins)\"\n",
+    "    ax.stairs(r.frequencies, r.bin_edges, fill=True, alpha=0.7)\n",
+    "    title = f\"Granularity {r.granularity} ({len(r.frequencies)} bins)\"\n",
     "    if r.is_best:\n",
     "        title += \" ★ BEST\"\n",
     "        ax.set_facecolor(\"#ffffee\")\n",

src/khisto/core/backend.py

@@ -170,10 +170,10 @@ def _format_runtime_error(
 
 
 def _process_histogram_file(
-    temp_output_file_path: str,
+    file_path: str,
 ) -> list[HistogramResult]:
     """Process exploratory JSON generated by khisto CLI."""
-    with open(temp_output_file_path, "r") as temp_output_file:
+    with open(file_path, "r") as temp_output_file:
         khisto_output: _KhistoOutput = _KhistoOutput.from_dict(
             json.load(temp_output_file)
         )

tests/core/test_backend.py

@@ -240,8 +240,7 @@ def test_series_selects_finest_interpretable_histogram(self, tmp_path):
         }
         self._write_json(tmp_path / "histogram.series.json", payload)
 
-        with (tmp_path / "histogram.series.json").open("r", encoding="utf-8") as stream:
-            results = _process_histogram_file(stream)
+        results = _process_histogram_file(str(tmp_path / "histogram.series.json"))
 
         assert len(results) == 3
         assert [result.granularity for result in results] == [0, 2, 3]
@@ -278,8 +277,7 @@ def test_series_keeps_finest_histogram_when_all_interpretable(self, tmp_path):
         }
         self._write_json(tmp_path / "histogram.series.json", payload)
 
-        with (tmp_path / "histogram.series.json").open("r", encoding="utf-8") as stream:
-            results = _process_histogram_file(stream)
+        results = _process_histogram_file(str(tmp_path / "histogram.series.json"))
 
         assert len(results) == 2
         assert [result.is_best for result in results] == [False, True]