doc: add examples#13
Merged
Merged
Conversation
- Updated index.rst to include a new Guides section with links to API Comparison and Demo. - Created a new documentation file for the function in khisto.matplotlib. - Removed the outdated requirements.txt file and migrated dependencies to the pyproject.toml under a new 'docs' section for better management.
marcboulle
requested changes
Apr 17, 2026
marcboulle
left a comment
marcboulle
left a comment
There was a problem hiding this comment.
Remarques minimalistes
Je ferai plutôt une relecture approfondie de la doc en mode utilisateur lors de la béta.
- Updated index.rst to include a new Guides section with links to API Comparison and Demo. - Created a new documentation file for the function in khisto.matplotlib. - Removed the outdated requirements.txt file and migrated dependencies to the pyproject.toml under a new 'docs' section for better management.
- Updated the main index.rst to provide a clearer introduction to Khisto, highlighting its adaptive binning capabilities and various entry points for users. - Added a description in matplotlib/index.rst to explain the use of khisto.matplotlib.hist for adaptive histogramming, emphasizing its convenience compared to traditional plt.hist.
…ntation references
Made dependency management better. clarified param x for hist api.
…erly managed and closed
fix: enforce 1-D input requirement for histogram functions and update tests
marcboulle
approved these changes
Apr 24, 2026
marcboulle
left a comment
marcboulle
left a comment
There was a problem hiding this comment.
LGTM
Les points essentiels sont résolus: je ferais la relecture détaillée finale lors de la phase de bêta-test.
…tent; update CSS for better styling
popescu-v
reviewed
Jun 17, 2026
popescu-v
reviewed
Jun 17, 2026
popescu-v
reviewed
Jun 17, 2026
popescu-v
reviewed
Jun 17, 2026
popescu-v
reviewed
Jun 17, 2026
popescu-v
reviewed
Jun 17, 2026
popescu-v
reviewed
Jun 17, 2026
popescu-v
reviewed
Jun 17, 2026
popescu-v
reviewed
Jun 17, 2026
popescu-v
reviewed
Jun 17, 2026
popescu-v
reviewed
Jun 17, 2026
popescu-v
reviewed
Jun 17, 2026
popescu-v
reviewed
Jun 17, 2026
popescu-v
requested changes
Jun 17, 2026
popescu-v
left a comment
popescu-v
left a comment
Contributor
There was a problem hiding this comment.
Several comments.
General remarks:
- use PEP 8 naming conventions systematically;
- systematically check input parameter types on public APIs.
popescu-v
reviewed
Jun 18, 2026
popescu-v
reviewed
Jun 18, 2026
- Updated index.rst to include a new Guides section with links to API Comparison and Demo. - Created a new documentation file for the function in khisto.matplotlib. - Removed the outdated requirements.txt file and migrated dependencies to the pyproject.toml under a new 'docs' section for better management.
- Updated the main index.rst to provide a clearer introduction to Khisto, highlighting its adaptive binning capabilities and various entry points for users. - Added a description in matplotlib/index.rst to explain the use of khisto.matplotlib.hist for adaptive histogramming, emphasizing its convenience compared to traditional plt.hist.
…ntation references
Made dependency management better. clarified param x for hist api.
…erly managed and closed
fix: enforce 1-D input requirement for histogram functions and update tests
…tent; update CSS for better styling
popescu-v
reviewed
Jun 18, 2026
popescu-v
approved these changes
Jun 19, 2026
popescu-v
left a comment
popescu-v
left a comment
Contributor
There was a problem hiding this comment.
LGTM, modulo the typing issues (to address in a subsequent PR).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.