Sign khisto binary#24
Merged
Merged
Conversation
bruno-at-orange
force-pushed
the
23-sign-windows-binaries-for-pip-packaging
branch
3 times, most recently
from
June 29, 2026 17:02
160daa1 to
5bb33d8
Compare
- Fix PR paths trigger: pack-pip.yml -> pack-pip.yaml - Add python-version: '3.13' to setup-python step - Move Set up Python and Set up UV before Build wheels - Fix download-artifact v6
bruno-at-orange
force-pushed
the
23-sign-windows-binaries-for-pip-packaging
branch
from
June 30, 2026 07:24
6994905 to
753249d
Compare
ElouenGinat
approved these changes
Jun 30, 2026
popescu-v
reviewed
Jul 6, 2026
popescu-v
reviewed
Jul 6, 2026
popescu-v
requested changes
Jul 6, 2026
popescu-v
left a comment
popescu-v
left a comment
Contributor
There was a problem hiding this comment.
Have single, non-conditional upload-artifact step at the end of the signing process (see the comment in this respect).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional signing of the khisto ` binary inside Windows x64 wheels using DigiCert Software Trust Manager.
Changes
New
workflow_dispatchinput:signature-activation(boolean, defaultfalse) — enables signing when triggering the workflow manually.Signing steps (Windows x64 only):
python -m wheel unpackSM_CLIENT_CERT_FILE_B64secretdigicert/code-signing-software-trust-actioninsimple-signing-modeARM64 Windows is not signed yet (smctl does not support it); a warning is emitted instead.
Other fixes:
actions/upload-artifactandactions/download-artifactfrom v6 to v7pull_requestpath trigger (.yml→.yaml)3.13insetup-pythonSet up PythonandSet up UVsteps beforeLoad Visual C++ Environment Variables