spirv-val: Fix 11805 to allow Uniform BufferBlock#6748
Open
spencer-lunarg wants to merge 1 commit into
Open
Conversation
Tobski
approved these changes
Jun 17, 2026
alan-baker
reviewed
Jun 17, 2026
alan-baker
left a comment
alan-baker
left a comment
Contributor
There was a problem hiding this comment.
I'm a bit confused. These decorations are exclusive, but one is required (in this context). What is being caught here differently? No tests were changed.
Contributor
|
@alan-baker See the linked issue, but TL;DR is that heap declarations of SSBOs don't require Block or BufferBlock, and you are supposed to be allowed to query array lengths on them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For https://gitlab.khronos.org/vulkan/vulkan/-/merge_requests/8263