[Editorial] Update Appendix A: device info descriptors#1027
Open
KornevNikita wants to merge 1 commit into
Open
[Editorial] Update Appendix A: device info descriptors#1027KornevNikita wants to merge 1 commit into
KornevNikita wants to merge 1 commit into
Conversation
These descriptors are deprecated. Add comments to Appendix A.
KornevNikita
changed the title
KornevNikita
commented
Jul 6, 2026
| struct atomic_fence_scope_capabilities; | ||
| struct profiling_timer_resolution; | ||
| struct is_endian_little; | ||
| struct is_endian_little; // Deprecated |
Contributor
Author
There was a problem hiding this comment.
What is the right indentation here and below?
Contributor
There was a problem hiding this comment.
Look like the algo what is_grouped_somewho_match_indentation ?
struct host_unified_memory; // Deprecated
struct max_constant_buffer_size; // Deprecated
struct max_constant_args; // Deprecated
struct is_compiler_available; // Deprecated
struct is_linker_available; // Deprecated
struct extensions; // Deprecated
So your current indentation look correct to me too
TApplencourt
approved these changes
Jul 7, 2026
| struct atomic_fence_scope_capabilities; | ||
| struct profiling_timer_resolution; | ||
| struct is_endian_little; | ||
| struct is_endian_little; // Deprecated |
Contributor
There was a problem hiding this comment.
Look like the algo what is_grouped_somewho_match_indentation ?
struct host_unified_memory; // Deprecated
struct max_constant_buffer_size; // Deprecated
struct max_constant_args; // Deprecated
struct is_compiler_available; // Deprecated
struct is_linker_available; // Deprecated
struct extensions; // Deprecated
So your current indentation look correct to me too
Contributor
|
LGTM. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These descriptors are deprecated. Add comments to Appendix A.