Fix missing property_list in image get_access description tables#997
Open
ssam18 wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Fix missing property_list in image get_access description tables#997ssam18 wants to merge 1 commit intoKhronosGroup:mainfrom
ssam18 wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
The synopsis for unsampled_image and sampled_image both include a property_list parameter on get_access and get_host_access, but the description tables in the member function docs were missing it. Align the descriptions with the synopsis and with DPC++ behavior.
Contributor
|
Thanks a lot! LGTM. |
TApplencourt
approved these changes
Apr 6, 2026
gmlueck
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #994.
The header synopsis for both
unsampled_imageandsampled_imageincludes aproperty_listparameter onget_accessandget_host_access, and DPC++ implements it that way too, but the description tables in the member function docs were missing it. This brings the prose descriptions in line with the synopsis for all four affected functions.