Add const char* overloads to sycl::nan to align with std::nan#999
Open
ssam18 wants to merge 1 commit intoKhronosGroup:mainfrom
Open
Add const char* overloads to sycl::nan to align with std::nan#999ssam18 wants to merge 1 commit intoKhronosGroup:mainfrom
ssam18 wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #842. Currently
sycl::nanonly accepts unsigned integer nancode arguments (inherited from OpenCL), whilestd::nan/std::nanf/std::nanltake aconst char*. This adds scalar overloads forfloat,double, andhalf, plusstd::array<const char*, N>overloads forvecandmarraywhere the element typeTmust be explicitly specified since it can't be deduced from the argument.