Skip to content

Commit 121cfd0

Browse files
cubanismocharles-lunarg
authored andcommitted
tests: Fix overflow in vkCreateSharedSwapchainsKHR
The test was creating two swapchains and storing the result in a non-array result variable.
1 parent 48eaacc commit 121cfd0

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

tests/loader_get_proc_addr_tests.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,10 @@ TEST(GetDeviceProcAddr, SwapchainFuncsWithTerminator) {
294294
infos[1].sType = VK_STRUCTURE_TYPE_SWAPCHAIN_CREATE_INFO_KHR;
295295
infos[1].surface = surface2;
296296

297-
ASSERT_EQ(VK_SUCCESS, CreateSharedSwapchainsKHR(dev.dev, 2, infos.data(), nullptr, &swapchain));
297+
std::array<VkSwapchainKHR, 2> swapchains{};
298+
ASSERT_EQ(VK_SUCCESS, CreateSharedSwapchainsKHR(dev.dev, static_cast<uint32_t>(swapchains.size()), infos.data(), nullptr,
299+
swapchains.data()));
300+
ASSERT_FALSE(log.find("vkCreateSharedSwapchainsKHR Terminator: No VkSurfaceKHR objects were created"));
298301
}
299302
env.vulkan_functions.vkDestroySurfaceKHR(inst.inst, surface, nullptr);
300303
env.vulkan_functions.vkDestroySurfaceKHR(inst.inst, surface2, nullptr);

0 commit comments

Comments
 (0)