Skip to content

Commit 48eaacc

Browse files
cubanismocharles-lunarg
authored andcommitted
fix: vkCreateSharedSwapchains stale bad list check
There was a backwards check for ICD surfaces in vkCreateSharedSwapchainsKHR, causing it to always fail if it was called with surface handles that had been used before. The correct version of this check now lives in the helper function wsi_unwrap_icd_surface(), so remove this broken and redundant one.
1 parent 19c64f9 commit 48eaacc

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

loader/wsi.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2207,12 +2207,6 @@ VKAPI_ATTR VkResult VKAPI_CALL terminator_CreateSharedSwapchainsKHR(VkDevice dev
22072207
"[VUID-vkCreateSharedSwapchainsKHR-device-parameter]");
22082208
abort(); /* Intentionally fail so user can correct issue. */
22092209
}
2210-
if (NULL != icd_term->surface_list.list) {
2211-
loader_log(NULL, VULKAN_LOADER_ERROR_BIT, 0,
2212-
"vkCreateSharedSwapchainsKHR Terminator: No VkSurfaceKHR objects were created, indicating an application "
2213-
"bug. Returning VK_SUCCESS. ");
2214-
return VK_SUCCESS;
2215-
}
22162210
if (NULL == dev->loader_dispatch.extension_terminator_dispatch.CreateSharedSwapchainsKHR) {
22172211
loader_log(NULL, VULKAN_LOADER_ERROR_BIT, 0,
22182212
"vkCreateSharedSwapchainsKHR Terminator: Driver's function pointer was NULL, returning VK_SUCCESS. Was the "

0 commit comments

Comments
 (0)