Fix macOS test shim crashing on init

Need to only use the mutex after initialization .

Author: charles-lunarg

tests/framework/shim/unix_shim.cpp

@@ -146,8 +146,16 @@ PFN_FPUTS real_fputs = nullptr;
 PFN_FPUTC real_fputc = nullptr;
 #endif
 
+// It would be nicer to use a lock_guard but due to the interposer, it isn't possible because these functions get called
+// before the shim_lock variable is finished initializing.
+#define LOCK_IF_NOT_IN_SETUP                                      \
+    std::unique_lock<std::recursive_mutex> lock{};                \
+    if (platform_shim.is_finished_setup) {                        \
+        lock = std::unique_lock<std::recursive_mutex>(shim_lock); \
+    }
+
 FRAMEWORK_EXPORT DIR* OPENDIR_FUNC_NAME(const char* path_name) {
-    std::lock_guard lg(shim_lock);
+    LOCK_IF_NOT_IN_SETUP
 #if !defined(__APPLE__)
     if (!real_opendir) real_opendir = (PFN_OPENDIR)dlsym(RTLD_NEXT, "opendir");
 #endif
@@ -166,7 +174,7 @@ FRAMEWORK_EXPORT DIR* OPENDIR_FUNC_NAME(const char* path_name) {
 }
 
 FRAMEWORK_EXPORT struct dirent* READDIR_FUNC_NAME(DIR* dir_stream) {
-    std::lock_guard lg(shim_lock);
+    LOCK_IF_NOT_IN_SETUP
 #if !defined(__APPLE__)
     if (!real_readdir) {
         if (sizeof(void*) == 8) {
@@ -227,7 +235,7 @@ FRAMEWORK_EXPORT struct dirent* READDIR_FUNC_NAME(DIR* dir_stream) {
 }
 
 FRAMEWORK_EXPORT int CLOSEDIR_FUNC_NAME(DIR* dir_stream) {
-    std::lock_guard lg(shim_lock);
+    LOCK_IF_NOT_IN_SETUP
 #if !defined(__APPLE__)
     if (!real_closedir) real_closedir = (PFN_CLOSEDIR)dlsym(RTLD_NEXT, "closedir");
 #endif
@@ -245,7 +253,7 @@ FRAMEWORK_EXPORT int CLOSEDIR_FUNC_NAME(DIR* dir_stream) {
 }
 
 FRAMEWORK_EXPORT int ACCESS_FUNC_NAME(const char* in_pathname, int mode) {
-    std::lock_guard lg(shim_lock);
+    LOCK_IF_NOT_IN_SETUP
 #if !defined(__APPLE__)
     if (!real_access) real_access = (PFN_ACCESS)dlsym(RTLD_NEXT, "access");
 #endif
@@ -268,7 +276,7 @@ FRAMEWORK_EXPORT int ACCESS_FUNC_NAME(const char* in_pathname, int mode) {
 }
 
 FRAMEWORK_EXPORT FILE* FOPEN_FUNC_NAME(const char* in_filename, const char* mode) {
-    std::lock_guard lg(shim_lock);
+    LOCK_IF_NOT_IN_SETUP
 #if !defined(__APPLE__)
     if (!real_fopen) real_fopen = (PFN_FOPEN)dlsym(RTLD_NEXT, "fopen");
 #endif
@@ -307,7 +315,7 @@ FRAMEWORK_EXPORT FILE* FOPEN_FUNC_NAME(const char* in_filename, const char* mode
 }
 
 FRAMEWORK_EXPORT void* DLOPEN_FUNC_NAME(const char* in_filename, int flags) {
-    std::lock_guard lg(shim_lock);
+    LOCK_IF_NOT_IN_SETUP
 #if !defined(__APPLE__)
     if (!real_dlopen) real_dlopen = (PFN_DLOPEN)dlsym(RTLD_NEXT, "dlopen");
 #endif
@@ -328,7 +336,7 @@ FRAMEWORK_EXPORT void* DLOPEN_FUNC_NAME(const char* in_filename, int flags) {
 }
 
 FRAMEWORK_EXPORT uid_t GETEUID_FUNC_NAME(void) {
-    std::lock_guard lg(shim_lock);
+    LOCK_IF_NOT_IN_SETUP
 #if !defined(__APPLE__)
     if (!real_geteuid) real_geteuid = (PFN_GETEUID)dlsym(RTLD_NEXT, "geteuid");
 #endif
@@ -341,7 +349,7 @@ FRAMEWORK_EXPORT uid_t GETEUID_FUNC_NAME(void) {
 }
 
 FRAMEWORK_EXPORT gid_t GETEGID_FUNC_NAME(void) {
-    std::lock_guard lg(shim_lock);
+    LOCK_IF_NOT_IN_SETUP
 #if !defined(__APPLE__)
     if (!real_getegid) real_getegid = (PFN_GETEGID)dlsym(RTLD_NEXT, "getegid");
 #endif
@@ -356,7 +364,7 @@ FRAMEWORK_EXPORT gid_t GETEGID_FUNC_NAME(void) {
 #if !defined(TARGET_OS_IPHONE)
 #if defined(HAVE_SECURE_GETENV)
 FRAMEWORK_EXPORT char* SECURE_GETENV_FUNC_NAME(const char* name) {
-    std::lock_guard lg(shim_lock);
+    LOCK_IF_NOT_IN_SETUP
 #if !defined(__APPLE__)
     if (!real_secure_getenv) real_secure_getenv = (PFN_SEC_GETENV)dlsym(RTLD_NEXT, "secure_getenv");
 #endif
@@ -369,7 +377,7 @@ FRAMEWORK_EXPORT char* SECURE_GETENV_FUNC_NAME(const char* name) {
 #endif
 #if defined(HAVE___SECURE_GETENV)
 FRAMEWORK_EXPORT char* __SECURE_GETENV_FUNC_NAME(const char* name) {
-    std::lock_guard lg(shim_lock);
+    LOCK_IF_NOT_IN_SETUP
 #if !defined(__APPLE__)
     if (!real__secure_getenv) real__secure_getenv = (PFN_SEC_GETENV)dlsym(RTLD_NEXT, "__secure_getenv");
 #endif
@@ -384,42 +392,42 @@ FRAMEWORK_EXPORT char* __SECURE_GETENV_FUNC_NAME(const char* name) {
 #endif
 
 FRAMEWORK_EXPORT int FPUTS_FUNC_NAME(const char* str, FILE* stream) {
+    LOCK_IF_NOT_IN_SETUP
 #if !defined(__APPLE__)
     if (!real_fputs) real_fputs = (PFN_FPUTS)dlsym(RTLD_NEXT, "fputs");
 #endif
     if (stream == stderr) {
-        std::lock_guard lg(shim_lock);
         platform_shim.fputs_stderr_log += str;
     }
     return real_fputs(str, stream);
 }
 
 FRAMEWORK_EXPORT int FPUTC_FUNC_NAME(int ch, FILE* stream) {
+    LOCK_IF_NOT_IN_SETUP
 #if !defined(__APPLE__)
     if (!real_fputc) real_fputc = (PFN_FPUTC)dlsym(RTLD_NEXT, "fputc");
 #endif
     if (stream == stderr) {
-        std::lock_guard lg(shim_lock);
         platform_shim.fputs_stderr_log += ch;
     }
     return real_fputc(ch, stream);
 }
 
 #if defined(__APPLE__)
 FRAMEWORK_EXPORT CFBundleRef my_CFBundleGetMainBundle() {
-    std::lock_guard lg(shim_lock);
+    LOCK_IF_NOT_IN_SETUP
     static CFBundleRef global_bundle{};
     return reinterpret_cast<CFBundleRef>(&global_bundle);
 }
 FRAMEWORK_EXPORT CFURLRef my_CFBundleCopyResourcesDirectoryURL([[maybe_unused]] CFBundleRef bundle) {
-    std::lock_guard lg(shim_lock);
+    LOCK_IF_NOT_IN_SETUP
     static CFURLRef global_url{};
     return reinterpret_cast<CFURLRef>(&global_url);
 }
 FRAMEWORK_EXPORT Boolean my_CFURLGetFileSystemRepresentation([[maybe_unused]] CFURLRef url,
                                                              [[maybe_unused]] Boolean resolveAgainstBase, UInt8* buffer,
                                                              CFIndex maxBufLen) {
-    std::lock_guard lg(shim_lock);
+    LOCK_IF_NOT_IN_SETUP
     if (!platform_shim.bundle_contents.empty()) {
         CFIndex copy_len = (CFIndex)platform_shim.bundle_contents.size();
         if (copy_len > maxBufLen) {