Disable formatting in generated test code#1699
Merged
charles-lunarg merged 1 commit intoMay 14, 2025
Merged
Conversation
|
CI Vulkan-Loader build queued with queue ID 443038. |
|
CI Vulkan-Loader build # 3027 running. |
|
CI Vulkan-Loader build queued with queue ID 443056. |
|
CI Vulkan-Loader build # 3028 running. |
|
CI Vulkan-Loader build # 3028 passed. |
jjulianoatnv
approved these changes
May 13, 2025
jjulianoatnv
left a comment
jjulianoatnv
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Thank you for quick response on this.
Collaborator
Author
|
No clue why mingw compiler started failing, but I highly doubt it was due to this change, since it is CMake declaring the compiler non-functional so it isn't even compiling the changed source files. Going to go ahead with the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is not much benefit in formatting the generated code, especially since different clang-format versions handle line breaks differently, causing lots of noise when generating source code.
This also makes developing without clang-format to be a bit easier, since the generated code is already properly formatted (for the most part).