Skip to content

ci: Test UBSAN + ASAN#1704

Merged
charles-lunarg merged 1 commit into
KhronosGroup:mainfrom
jpr42:ubsan
May 20, 2025
Merged

ci: Test UBSAN + ASAN#1704
charles-lunarg merged 1 commit into
KhronosGroup:mainfrom
jpr42:ubsan

Conversation

@jpr42

@jpr42 jpr42 commented May 18, 2025

Copy link
Copy Markdown
Contributor

Currently UBSAN isn't being tested on CI

@ci-tester-lunarg

Copy link
Copy Markdown

Author jpr42 not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg

Copy link
Copy Markdown

Author jpr42 not on autobuild list. Waiting for curator authorization before starting CI build.

@CLAassistant

CLAassistant commented May 18, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Currently UBSAN isn't being tested on CI
@ci-tester-lunarg

Copy link
Copy Markdown

Author jpr42 not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg

Copy link
Copy Markdown

Author jpr42 not on autobuild list. Waiting for curator authorization before starting CI build.

Comment thread loader/CMakeLists.txt
Comment on lines +433 to +434
target_compile_options(vulkan PUBLIC -fsanitize=address,undefined)
target_link_options(vulkan PUBLIC -fsanitize=address,undefined)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To save CI time just combine them.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This affects regular developers (so, ME). Which is fine, I should be using this locally anyhow.

@jpr42 jpr42 marked this pull request as ready for review May 18, 2025 23:19
Comment on lines -62 to -64
# This is to combat a bug when using 6.6 linux kernels with thread/address sanitizer
# https://github.com/google/sanitizers/issues/1716
- run: sudo sysctl vm.mmap_rnd_bits=28

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely safe to remove - I love removing workarounds for bugs that no longer affect us.

Comment thread loader/CMakeLists.txt
Comment on lines +433 to +434
target_compile_options(vulkan PUBLIC -fsanitize=address,undefined)
target_link_options(vulkan PUBLIC -fsanitize=address,undefined)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This affects regular developers (so, ME). Which is fine, I should be using this locally anyhow.

@charles-lunarg charles-lunarg merged commit c913466 into KhronosGroup:main May 20, 2025
44 checks passed
@jpr42 jpr42 deleted the ubsan branch May 20, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants