Don't crash on null dispatchable handle.#1707
Closed
zaiste-linganer wants to merge 1 commit into
Closed
Conversation
|
Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author zaiste-linganer not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
Contributor
Author
|
@charles-lunarg Please have a look. |
Contributor
Author
|
@06393993 FYI |
Contributor
Author
|
Gentle ping for @charles-lunarg to have a look. We were able to test it with failing driver scenario, and this allows to propagate the return value clearly to the application, without the crash in the loader. |
|
CI Vulkan-Loader build queued with queue ID 459598. |
|
CI Vulkan-Loader build # 3068 running. |
|
CI Vulkan-Loader build # 3068 passed. |
Collaborator
|
Closing for the reasons stated in #1706 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #1706.
Ideally, I'd prefer to return an error here, but I'm ok with just skipping the crash.