Add proper stdcall name mangling to gas assembly on 32bit windows#1762
Conversation
|
Author BtbN not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author BtbN not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
charles-lunarg
left a comment
charles-lunarg
left a comment
There was a problem hiding this comment.
Yep, sometimes need these kind of things to work with calling conventions. Thanks for giving it a go and making a PR! Will let it run through CI to see if anything happens first before merging.
|
CI Vulkan-Loader build queued with queue ID 511055. |
|
CI Vulkan-Loader build # 3155 running. |
|
Would it make sense to also add a test to CI for this? Cause right now nothing will actually test it, mingw-use-gas only runs for 64bit. |
|
Would it make sense? Yes, more coverage is good. But it would add yet another configuration to the test matrix which is already somewhat crowded. Being that 32 bit is really only to allow compatibility with older titles, especially ones not built in the last decade, I am against adding it just as its a very low usage domain. |
|
CI Vulkan-Loader build # 3155 passed. |
4 participants
This fixes #1761
Also fixes the flood of warnings during linking by explicitly enabling stdcall fixup.