fix: handle multi-layer setting additions and fix settings equality checks

[JJLovesLife]

Fix deduplicate layer logic when multiple layers added by a single manifest in loader_add_layer_properties. Also fix missing fields in settings equality checks.

[ci-tester-lunarg]

Author JJLovesLife not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author JJLovesLife not on autobuild list. Waiting for curator authorization before starting CI build.

[CLAassistant]

All committers have signed the CLA.

[JJLovesLife]

I'm reading the Vulkan loader source code these days, and found some issues in the setting loading logic.

1. loader_add_layer_properties may load multiple layers, and the deduplicate logic don't handle it correctly.
2. setting equality check missed some fields, and update_global_loader_settings cleared global setting before compare. Let me know if you'd like just remove that logic.

Also let me know, if any test is needed in this change. And if an issue is needed.

[charles-lunarg]

loader_add_layer_properties may load multiple layers, and the deduplicate logic don't handle it correctly.

Can you clarify what you mean? Yes, loader_add_layer_properties can add multiple layers as the manifest might have an array of layers. Is it that the deduplication logic occurs before any calls to loader_add_layer_properties are made, so if the manifest contains the same layer twice, it'll be added? Cause yeah, thats a bug, but its also a 'layer manifest authors, please don't do that ....' (I think I understand your statement, looking through the source code made it pretty clear, just wanted to confirm.)

update_global_loader_settings cleared global setting before compare. Let me know if you'd like just remove that logic.

That just sounds like a bug. Whoops!

Edit: Now that I did a code review - it seems both things are fixed in the PR. Thanks!

[charles-lunarg]

Changes look to fix all the problems described.
Will approve it & let CI run, assuming it passes its should be good to go.

[ci-tester-lunarg]

CI Vulkan-Loader build queued with queue ID 685172.

[ci-tester-lunarg]

CI Vulkan-Loader build # 3455 running.

[charles-lunarg]

Oh FYI the code needs to be formatted with clang-format-16 in order to pass the CI check.

[ci-tester-lunarg]

CI Vulkan-Loader build # 3455 passed.

[ci-tester-lunarg]

Author JJLovesLife not on autobuild list. Waiting for curator authorization before starting CI build.

[ci-tester-lunarg]

Author JJLovesLife not on autobuild list. Waiting for curator authorization before starting CI build.

[JJLovesLife]

Oh FYI the code needs to be formatted with clang-format-16 in order to pass the CI check.

Oops, sorry I forgot to format the code😜 I've updated it now and should also resolved the testing failure.

[ci-tester-lunarg]

CI Vulkan-Loader build queued with queue ID 685993.

[ci-tester-lunarg]

CI Vulkan-Loader build # 3457 running.

[ci-tester-lunarg]

CI Vulkan-Loader build # 3457 passed.