Skip to content

Use std::unordered_set<vk::Extend2D> instead of std::set<vk::Extent2D> to determine number of unique extents. #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asuessenbach wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Use std::unordered_set<vk::Extend2D> instead of std::set<vk::Extent2D> to determine number of unique extents. #1517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions framework/rendering/render_target.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include "core/hpp_image.h"
#include "core/hpp_image_view.h"
#include "core/image.h"
#include <vulkan/vulkan_hash.hpp> // provides std::hash specializations for Vulkan handle types, used in std::unordered_map and std::unordered_set

namespace vkb
{
Expand Down Expand Up @@ -239,7 +240,7 @@ inline void RenderTarget<bindingType>::init(std::vector<vkb::core::HPPImage> &&i
auto get_image_extent = [](const vkb::core::HPPImage &image) { return vk::Extent2D{image.get_extent().width, image.get_extent().height}; };

// Constructs a set of unique image extents given a vector of images
std::set<vk::Extent2D> unique_extent;
std::unordered_set<vk::Extent2D> unique_extent;
std::ranges::transform(images, std::inserter(unique_extent, unique_extent.end()), get_image_extent);

// Allow only one extent size for a render target
Expand Down Expand Up @@ -293,7 +294,7 @@ inline void RenderTarget<bindingType>::init(std::vector<vkb::core::HPPImageView>

// Constructs a set of unique image extents given a vector of image views;
// allow only one extent size for a render target
std::set<vk::Extent2D> unique_extent;
std::unordered_set<vk::Extent2D> unique_extent;
std::ranges::transform(views, std::inserter(unique_extent, unique_extent.end()), get_view_extent);
if (unique_extent.size() != 1)
{
Expand Down
Loading