fix(wayland): restore focus during window resize#1520
Open
Kkaiwz wants to merge 1 commit intoKhronosGroup:mainfrom
Open
fix(wayland): restore focus during window resize#1520Kkaiwz wants to merge 1 commit intoKhronosGroup:mainfrom
Kkaiwz wants to merge 1 commit intoKhronosGroup:mainfrom
Conversation
fd7445e to
56edade
Compare
On Wayland, when the user resizes a window, the compositor takes over input handling. This causes GLFW to receive a keyboardHandleLeave event, which it incorrectly interprets as the window losing focus. This will result in Platform::update() no longer executed, then the render result is incorrect. This patch forces focus to be restored in the window size callback on Wayland, ensuring that rendering continues during resize operations. Signed-off-by: Ryan Zhang <ryan.zhang@nxp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Wayland, when the user resizes a window, the compositor takes over input handling. This causes GLFW to receive a keyboardHandleLeave event, which it incorrectly interprets as the window losing focus. This will result in Platform::update() no longer executed, then the render result is incorrect.
This patch forces focus to be restored in the window size callback on Wayland, ensuring that rendering continues during resize operations.
Description
Please include a summary of the change, new sample or fixed issue. Please also include relevant motivation and context.
Please read the contribution guidelines
Fixes #
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: