Skip to content

Commit 04b57bb

Browse files
committed
tests: Remove old comments
1 parent cc0e7cb commit 04b57bb

2 files changed

Lines changed: 4 additions & 10 deletions

File tree

tests/unit/sync_object.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4407,11 +4407,10 @@ TEST_F(NegativeSyncObject, DecreasingTimelineSignals) {
44074407

44084408
m_default_queue->Submit(vkt::no_cmd, vkt::TimelineSignal(semaphore, 2));
44094409

4410-
// NOTE: VerifyFound goes after Wait because validation is performed by the Queue thread
44114410
m_errorMonitor->SetDesiredError("VUID-VkSubmitInfo-pSignalSemaphores-03242");
44124411
m_default_queue->Submit(vkt::no_cmd, vkt::TimelineSignal(semaphore, 1));
4413-
m_default_queue->Wait();
44144412
m_errorMonitor->VerifyFound();
4413+
m_default_queue->Wait();
44154414
}
44164415

44174416
TEST_F(NegativeSyncObject, TimelineHostSignalLargerThanPendingSignal) {
@@ -4467,11 +4466,10 @@ TEST_F(NegativeSyncObject, DifferentSignalingOrderThanSubmitOrder) {
44674466
m_default_queue->Submit(vkt::no_cmd, vkt::TimelineSignal(semaphore, 2));
44684467

44694468
// Signal 3 resolves wait 1 then value 2 is signaled
4470-
// NOTE: VerifyFound goes after Wait because validation is performed by the Queue thread
44714469
m_errorMonitor->SetDesiredError("VUID-VkSubmitInfo-pSignalSemaphores-03242");
44724470
m_second_queue->Submit(vkt::no_cmd, vkt::TimelineSignal(semaphore, 3));
4473-
m_default_queue->Wait();
44744471
m_errorMonitor->VerifyFound();
4472+
m_default_queue->Wait();
44754473
}
44764474

44774475
TEST_F(NegativeSyncObject, DifferentSignalingOrderThanSubmitOrder2) {
@@ -4491,11 +4489,10 @@ TEST_F(NegativeSyncObject, DifferentSignalingOrderThanSubmitOrder2) {
44914489
m_default_queue->Submit2(vkt::no_cmd, vkt::TimelineSignal(semaphore, 1));
44924490

44934491
// Signal 3 resolves wait 1 then value 1 is signaled
4494-
// NOTE: VerifyFound goes after Wait because validation is performed by the Queue thread
44954492
m_errorMonitor->SetDesiredError("VUID-VkSubmitInfo2-semaphore-03882");
44964493
m_second_queue->Submit2(vkt::no_cmd, vkt::TimelineSignal(semaphore, 3));
4497-
m_default_queue->Wait();
44984494
m_errorMonitor->VerifyFound();
4495+
m_default_queue->Wait();
44994496
}
45004497

45014498
TEST_F(NegativeSyncObject, BinarySyncDependsOnTimelineWait) {

tests/unit/wsi.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3231,11 +3231,8 @@ TEST_F(NegativeWsi, PresentImageWithWrongLayout2) {
32313231

32323232
m_errorMonitor->SetDesiredError("VUID-VkPresentInfoKHR-pImageIndices-01430");
32333233
m_default_queue->Present(m_swapchain, image_index, acquire_semaphore);
3234-
m_default_queue->Wait();
3235-
// NOTE: in the current implementation submit time validation is run by the queue thread
3236-
// (so all dependencies are resolved), that's why we check vuid after Wait(). There's an idea
3237-
// to move this validation to actual submit/present call, then we can put Verify after Present.
32383234
m_errorMonitor->VerifyFound();
3235+
m_default_queue->Wait();
32393236
}
32403237

32413238
TEST_F(NegativeWsi, CreatingSwapchainWithExtent) {

0 commit comments

Comments
 (0)