gpuav: Create descriptor encodings buffer once

Author: arno-lunarg

layers/gpuav/descriptor_validation/gpuav_descriptor_set.cpp

@@ -35,6 +35,7 @@ namespace gpuav {
 DescriptorSetSubState::DescriptorSetSubState(const vvl::DescriptorSet& set, Validator& state_data)
     : vvl::DescriptorSetSubState(set), descriptor_encodings_(state_data) {
     BuildBindingLayouts();
+    CreateDescriptorEncodingBuffer();
 }
 
 DescriptorSetSubState::~DescriptorSetSubState() { descriptor_encodings_.Destroy(); }
@@ -55,6 +56,21 @@ void DescriptorSetSubState::BuildBindingLayouts() {
     }
 }
 
+void DescriptorSetSubState::CreateDescriptorEncodingBuffer() {
+    VkBufferCreateInfo buffer_info = vku::InitStruct<VkBufferCreateInfo>();
+    buffer_info.size = base.GetNonInlineDescriptorCount() * sizeof(glsl::DescriptorEncoding);
+    buffer_info.usage = VK_BUFFER_USAGE_STORAGE_BUFFER_BIT | VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT;
+
+    // The descriptor state buffer can be very large (4mb+ in some games). Allocating it as HOST_CACHED
+    // and manually flushing it at the end of the state updates is faster than using HOST_COHERENT.
+    VmaAllocationCreateInfo alloc_info{};
+    alloc_info.requiredFlags = VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_CACHED_BIT;
+    const VkResult result = descriptor_encodings_.Create(&buffer_info, &alloc_info);
+    if (result != VK_SUCCESS) {
+        return;
+    }
+}
+
 template <typename StateObject>
 DescriptorId GetId(const StateObject* obj, bool allow_null = true) {
     if (!obj) {
@@ -175,34 +191,16 @@ VkDeviceAddress DescriptorSetSubState::GetDescriptorEncodingsAddress(Validator&
     std::lock_guard guard(state_lock_);
     const uint32_t current_version = current_version_.load();
 
-    // Will be empty on first time getting the state
-    if (descriptor_encodings_.Address() != 0) {
-        if (last_used_version_ == current_version) {
-            return descriptor_encodings_.Address();  // nothing has changed
-        } else {
-            // will replace (descriptor array size might have change, so need to resize buffer)
-            descriptor_encodings_.Destroy();
-        }
-    }
+    assert(descriptor_encodings_.Address() != 0);
 
-    last_used_version_ = current_version;
-
-    if (base.GetNonInlineDescriptorCount() == 0) {
-        // no descriptors case, return a dummy state object
+    if (last_used_version_ == current_version) {
+        // nothing has changed
         return descriptor_encodings_.Address();
     }
 
-    VkBufferCreateInfo buffer_info = vku::InitStruct<VkBufferCreateInfo>();
-    buffer_info.size = base.GetNonInlineDescriptorCount() * sizeof(glsl::DescriptorEncoding);
-    buffer_info.usage = VK_BUFFER_USAGE_STORAGE_BUFFER_BIT | VK_BUFFER_USAGE_SHADER_DEVICE_ADDRESS_BIT;
-
-    // The descriptor state buffer can be very large (4mb+ in some games). Allocating it as HOST_CACHED
-    // and manually flushing it at the end of the state updates is faster than using HOST_COHERENT.
-    VmaAllocationCreateInfo alloc_info{};
-    alloc_info.requiredFlags = VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_CACHED_BIT;
-    const VkResult result = descriptor_encodings_.Create(&buffer_info, &alloc_info);
-    if (result != VK_SUCCESS) {
-        return 0;
+    if (base.GetNonInlineDescriptorCount() == 0) {
+        // no descriptors, return a dummy state object
+        return descriptor_encodings_.Address();
     }
 
     auto descriptor_encodings = (glsl::DescriptorEncoding*)descriptor_encodings_.GetMappedPtr();
@@ -245,6 +243,8 @@ VkDeviceAddress DescriptorSetSubState::GetDescriptorEncodingsAddress(Validator&
     // Flush the descriptor encodings before unmapping so that they are visible to the GPU
     descriptor_encodings_.FlushAllocation();
 
+    last_used_version_ = current_version;
+
     return descriptor_encodings_.Address();
 }
 

layers/gpuav/descriptor_validation/gpuav_descriptor_set.h

@@ -50,6 +50,7 @@ class DescriptorSetSubState : public vvl::DescriptorSetSubState {
 
   private:
     void BuildBindingLayouts();
+    void CreateDescriptorEncodingBuffer();
 
     std::vector<gpuav::spirv::BindingLayout> binding_layouts_;