Skip to content

layers: Add VK_EXT_external_semaphore_drm_syncobj#11791

Draft
mahkoh wants to merge 2 commits into
KhronosGroup:mainfrom
mahkoh:jorth/syncobj
Draft

layers: Add VK_EXT_external_semaphore_drm_syncobj#11791
mahkoh wants to merge 2 commits into
KhronosGroup:mainfrom
mahkoh:jorth/syncobj

Conversation

@mahkoh

@mahkoh mahkoh commented Mar 4, 2026

Copy link
Copy Markdown

@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

Author mahkoh not on autobuild list. Waiting for curator authorization before starting CI build.

@CLAassistant

CLAassistant commented Mar 4, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

Author mahkoh not on autobuild list. Waiting for curator authorization before starting CI build.

@spencer-lunarg

Copy link
Copy Markdown
Contributor

@mahkoh this looks good, I know the VVL coverage was very minimal, for sake of making everyone's life easy, feel free to just leave this here, and when the extension is added, we will pull it VVL with a header update (all the generated code) and then you can just rebase this, with the new generated VUs and we should be good to go

The only thing I will ask then (not now, but before merging) is to

  1. Add a test to make sure the VUs get triggered
  2. Add 1 positive test using the extension correctly, this greatly reduces false positive regressions in VVL

@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

Author mahkoh not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

Author mahkoh not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

Author mahkoh not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

Author mahkoh not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

Author mahkoh not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

Author mahkoh not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

Author mahkoh not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg

Copy link
Copy Markdown
Collaborator

Author mahkoh not on autobuild list. Waiting for curator authorization before starting CI build.

@mahkoh

mahkoh commented May 14, 2026

Copy link
Copy Markdown
Author

I've added the requested tests and fixed a pre-existing bug.

Comment on lines +1463 to +1464
auto exportable_types = FindSupportedExternalSemaphoreHandleTypes(Gpu(), VK_EXTERNAL_SEMAPHORE_FEATURE_EXPORTABLE_BIT);
exportable_types &= ~VK_EXTERNAL_SEMAPHORE_HANDLE_TYPE_DRM_SYNCOBJ_BIT_EXT;

@mahkoh mahkoh May 14, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure why this is necessary. Does the vulkan device in CI set all bits here? This is not necessary when I run the test locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants