layers: Cleanup submit time tracker#12069
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 704411. |
|
CI Vulkan-ValidationLayers build # 23096 running. |
| @@ -180,20 +170,34 @@ bool SubmitTimeTracker::PropagateTimelineSignals() { | |||
|
|
|||
| bool SubmitTimeTracker::CanBeResolved(const UnresolvedBatch& batch) const { | |||
There was a problem hiding this comment.
so even if ALL unresolved_timeline_waits are invalid (GetTimelineValue returns null) we will still return true here?
There was a problem hiding this comment.
Yes, that's the intention.
a) it means there are other error reported elsewhere (like semaphore delete while still in use).
b) then we allow to resolve batch (remove from list) otherwise the queue will grow forever beause of blocking batch.
Make validity check part of timeline queries. In the initial version CanBeResolved missed semaphore validity check
artem-lunarg
force-pushed
the
artem-submit-time-cleanup
branch
from
4fe4b3a to
d989ced
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 704449. |
|
CI Vulkan-ValidationLayers build # 23098 running. |
|
CI Vulkan-ValidationLayers build # 23098 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 704563. |
|
CI Vulkan-ValidationLayers build # 23100 running. |
|
CI Vulkan-ValidationLayers build # 23100 passed. |
3 participants
Make validity check part of timeline queries.
In the initial version
CanBeResolvedmissed semaphore validity check