layers: Remove QueueSubmissionValidator#12072
Conversation
Move timeline signal validation from QueueSubmissionValidator to SubmitTimeTracker and remove QueueSubmissionValidator
|
CI Vulkan-ValidationLayers build queued with queue ID 704664. |
|
CI Vulkan-ValidationLayers build # 23101 running. |
| skip |= submit_time_tracker.ProcessSubmitInfo(submit, queue, submit_loc); | ||
| // Run submit time validation only if skip is not set. This is mostly for vvl testing, | ||
| // some tests expect that submit state is not updated if regular validation fails | ||
| if (!skip) { |
There was a problem hiding this comment.
Found more tests that rely on submit state is not updated in case of errors. The tests look fine, implement some non-trivial synchronization sequence, so don't want to change them. Instead experimenting with not running submit time validation if there are previous errors.
In theory we could split tests like NegativeSyncObject.QueueSubmitTimelineSemaphoreValue into smaller parts, but convoluted sync sequences might be useful for testing. Splitting can be considered as alternative if we have more issues.
spencer-lunarg
left a comment
spencer-lunarg
left a comment
There was a problem hiding this comment.
seems logical, see if CI is happy as well
|
Mac-M4 Debug can't clone, everything else works. |
3 participants
Move timeline signal validation from
QueueSubmissionValidatortoSubmitTimeTracker.Remove
QueueSubmissionValidator.