sync: Stop using SyncOpBase::Validate for pipeline barriers#12703
Merged
artem-lunarg merged 1 commit intoJul 14, 2026
Merged
Conversation
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 38903. |
Collaborator
|
CI Vulkan-ValidationLayers build # 23913 running. |
spencer-lunarg
approved these changes
Jul 13, 2026
Collaborator
|
CI Vulkan-ValidationLayers build # 23913 failed. |
Collaborator
|
CI Vulkan-ValidationLayers build queued with queue ID 39417. |
Collaborator
|
CI Vulkan-ValidationLayers build # 23920 running. |
Contributor
Author
|
Unrelated NegativeShaderObject.TessellationControlNextStage crash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This final goal here is to do something (probably disappear in a smart way) with
ReplayStateinsync_op.h(because it's ugly and confusing). To better understand this area I started with the adjacentSyncOpBase.SyncOpBase::Validatewas virtual but not really used in a polymorphic way. Instead aSyncOpBase-derived object was created whenever something needed to be validated at record time. This PR starts with pipeline barriers. Instead of creatingSyncOpto call Validate from it, the new approach implements validation inValidatePipelineBarrierhelper shared between sync1/sync2. Initialization ofBarrierSetis also simplified - in most cases it's enough to use sync1 or sync2 constructor.