refactor: remove token budget from app#1032
Conversation
WalkthroughThis PR removes the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @leonardmq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the application by eliminating the client-side management of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gemini review |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Code Review
This pull request refactors the application to remove the token_budget parameter from the GEPA job creation process. The change is motivated by the desire to control this parameter remotely without requiring an app release. The refactoring is comprehensive, touching on API client models, backend API logic, frontend components, data models, and extensive test suites. The removal of token_budget is consistently applied across all affected files. The code changes are clean and the updated tests ensure that the removal did not introduce any regressions. Overall, this is a well-executed refactoring that achieves its goal effectively.
📊 Coverage ReportOverall Coverage: 91% Diff: origin/leonard/kil-403-gepa-exclude-docs-from-zip...HEADNo lines with coverage information in this diff.
|
There was a problem hiding this comment.
Code Review
This pull request effectively removes the token_budget parameter from the application, making it remotely controlled by the server. This change simplifies the client and allows for easier adjustments. The refactoring is comprehensive, with consistent updates across the API client, backend, data models, UI, and tests. All changes are correct and the test suite has been properly updated to reflect the removal. I found no issues with this implementation; it's a clean and well-executed refactoring.
…om:Kiln-AI/Kiln into leonard/kil-402-gepa-remove-light-medium-high
c04ad39
into
leonard/kil-403-gepa-exclude-docs-from-zip
What does this PR do?
PR going into #1031
App does no longer expose token budget - now remote controlled to be able to adjust without needing an app release.
Need a server deploy - corresponding service PR must go first.
Checklists
Summary by CodeRabbit