Skip to content

KIL-612 Update out of date model strings#1348

Merged
sfierro merged 1 commit intomainfrom
KIL-612/out-of-date-string
Apr 27, 2026
Merged

KIL-612 Update out of date model strings#1348
sfierro merged 1 commit intomainfrom
KIL-612/out-of-date-string

Conversation

@sfierro
Copy link
Copy Markdown
Contributor

@sfierro sfierro commented Apr 24, 2026

No description provided.

@sfierro sfierro requested review from chiang-daniel, leonardmq, scosman and tawnymanticore and removed request for scosman April 24, 2026 23:25
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5cb16ef3-14d4-440a-a384-82bd3d6dfac8

📥 Commits

Reviewing files that changed from the base of the PR and between 084b795 and c6cd4f8.

📒 Files selected for processing (1)
  • app/web_ui/src/lib/ui/run_config_component/available_models_dropdown.svelte

Walkthrough

This pull request updates warning messages in the available models dropdown component, replacing four hardcoded warning texts with template-string messages that guide users to select a model marked "Recommended" in the dropdown. The change affects messaging for data generation, uncensored data generation, evaluations, and document extraction workflows.

Changes

Cohort / File(s) Summary
Warning Message Updates
app/web_ui/src/lib/ui/run_config_component/available_models_dropdown.svelte
Replaces hardcoded Warning messages for data_gen, uncensored_data_gen, evals, and doc_extraction with template-string messages instructing users to select a model marked "Recommended" in the dropdown.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

codex

Suggested reviewers

  • scosman

Poem

🐰 The warnings now whisper with grace,
"Find the badge marked Recommended—that's the place!"
No hardcoded names, just a gentle guide,
Four workflows improved, with clarity and pride! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is completely empty, missing all required sections: objective description, related issues link, contributor license agreement confirmation, and checklists. Add a complete description following the template: explain the purpose of updating the model strings, link to issue KIL-612, confirm the CLA, and check off the testing and documentation checklists.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references issue KIL-612 and accurately describes the main change: updating outdated model strings in the available_models_dropdown component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch KIL-612/out-of-date-string

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

📊 Coverage Report

Overall Coverage: 45%

Diff: origin/main...HEAD

No lines with coverage information in this diff.


Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the available_models_dropdown.svelte component to replace specific model names in warning messages with a generic recommendation to use models marked as "Recommended" in the dropdown. The review feedback suggests making these messages dynamic to provide positive reinforcement when a recommended model is selected, rather than showing a redundant suggestion. Additionally, a missed reference to a specific model name on line 379 was identified for correction.

? "success"
: "warning"}
warning_message="For this data gen template we suggest a large uncensored model like Grok 4."
warning_message={`For this data gen template we suggest using one of the models marked "Recommended" in the dropdown.`}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider making this message dynamic to confirm when a recommended model is selected for uncensored data generation, avoiding the redundant suggestion.

      warning_message={selected_model_suggested_uncensored_data_gen ? 'This model is recommended for this data gen template.' : 'For this data gen template we suggest using one of the models marked "Recommended" in the dropdown.'}

@sfierro sfierro merged commit b4e9a4f into main Apr 27, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants