refactor(kiloclaw): share morning briefing delivery constants

Extract delivery channel/status/reason enums into a shared module and reuse them in gateway response schemas and plugin delivery utilities to prevent drift.

Author: joshavant

services/kiloclaw/plugins/kiloclaw-morning-briefing/src/delivery-utils.ts

@@ -1,18 +1,18 @@
 import { formatBriefingMarkdownForMessage } from './briefing-utils';
 import { type CommandCapableRuntime, isTimeoutExecutionError, runCommand } from './command-utils';
+import {
+  MORNING_BRIEFING_DELIVERY_CHANNELS,
+  MORNING_BRIEFING_DELIVERY_REASONS,
+  MORNING_BRIEFING_DELIVERY_STATUSES,
+} from '../../../src/durable-objects/morning-briefing-delivery-constants';
 
-export const DELIVERY_CHANNELS = ['telegram', 'discord', 'slack'] as const;
+export const DELIVERY_CHANNELS = MORNING_BRIEFING_DELIVERY_CHANNELS;
 export type DeliveryChannel = (typeof DELIVERY_CHANNELS)[number];
 
-export const DELIVERY_STATUSES = ['sent', 'skipped', 'failed'] as const;
+export const DELIVERY_STATUSES = MORNING_BRIEFING_DELIVERY_STATUSES;
 export type DeliveryStatus = (typeof DELIVERY_STATUSES)[number];
 
-export const DELIVERY_REASONS = [
-  'missing_target',
-  'ambiguous_target',
-  'send_failed',
-  'config_unavailable',
-] as const;
+export const DELIVERY_REASONS = MORNING_BRIEFING_DELIVERY_REASONS;
 export type DeliveryReason = (typeof DELIVERY_REASONS)[number];
 
 export type BriefingDeliveryResult = {

services/kiloclaw/src/durable-objects/gateway-controller-types.ts

@@ -1,4 +1,9 @@
 import { z, type ZodType } from 'zod';
+import {
+  MORNING_BRIEFING_DELIVERY_CHANNELS,
+  MORNING_BRIEFING_DELIVERY_REASONS,
+  MORNING_BRIEFING_DELIVERY_STATUSES,
+} from './morning-briefing-delivery-constants';
 
 export type GatewayProcessStatus = {
   state: 'stopped' | 'starting' | 'running' | 'stopping' | 'crashed' | 'shutting_down';
@@ -104,21 +109,12 @@ const MorningBriefingSourceReadinessSchema = z.object({
   summary: z.string(),
 });
 
-const DELIVERY_CHANNELS = ['telegram', 'discord', 'slack'] as const;
-const DELIVERY_STATUSES = ['sent', 'skipped', 'failed'] as const;
-const DELIVERY_REASONS = [
-  'missing_target',
-  'ambiguous_target',
-  'send_failed',
-  'config_unavailable',
-] as const;
-
 const MorningBriefingDeliverySchema = z.object({
-  channel: z.enum(DELIVERY_CHANNELS),
-  status: z.enum(DELIVERY_STATUSES),
+  channel: z.enum(MORNING_BRIEFING_DELIVERY_CHANNELS),
+  status: z.enum(MORNING_BRIEFING_DELIVERY_STATUSES),
   target: z.string().optional(),
   accountId: z.string().optional(),
-  reason: z.enum(DELIVERY_REASONS).optional(),
+  reason: z.enum(MORNING_BRIEFING_DELIVERY_REASONS).optional(),
   error: z.string().optional(),
 });
 

services/kiloclaw/src/durable-objects/morning-briefing-delivery-constants.ts

@@ -0,0 +1,10 @@
+export const MORNING_BRIEFING_DELIVERY_CHANNELS = ['telegram', 'discord', 'slack'] as const;
+
+export const MORNING_BRIEFING_DELIVERY_STATUSES = ['sent', 'skipped', 'failed'] as const;
+
+export const MORNING_BRIEFING_DELIVERY_REASONS = [
+  'missing_target',
+  'ambiguous_target',
+  'send_failed',
+  'config_unavailable',
+] as const;