refactor(kiloclaw): dedupe delivery enums via shared constants

Define morning briefing delivery channel/status/reason enums once and reuse them in both plugin delivery logic and gateway controller response schemas to prevent drift.

Author: joshavant

services/kiloclaw/plugins/kiloclaw-morning-briefing/src/delivery-constants.ts

@@ -0,0 +1,10 @@
+export const DELIVERY_CHANNELS = ['telegram', 'discord', 'slack'] as const;
+
+export const DELIVERY_STATUSES = ['sent', 'skipped', 'failed'] as const;
+
+export const DELIVERY_REASONS = [
+  'missing_target',
+  'ambiguous_target',
+  'send_failed',
+  'config_unavailable',
+] as const;

services/kiloclaw/plugins/kiloclaw-morning-briefing/src/delivery-utils.ts

@@ -1,18 +1,11 @@
 import { formatBriefingMarkdownForMessage } from './briefing-utils';
 import { type CommandCapableRuntime, isTimeoutExecutionError, runCommand } from './command-utils';
+import { DELIVERY_CHANNELS, DELIVERY_REASONS, DELIVERY_STATUSES } from './delivery-constants';
 
-export const DELIVERY_CHANNELS = ['telegram', 'discord', 'slack'] as const;
 export type DeliveryChannel = (typeof DELIVERY_CHANNELS)[number];
 
-export const DELIVERY_STATUSES = ['sent', 'skipped', 'failed'] as const;
 export type DeliveryStatus = (typeof DELIVERY_STATUSES)[number];
 
-export const DELIVERY_REASONS = [
-  'missing_target',
-  'ambiguous_target',
-  'send_failed',
-  'config_unavailable',
-] as const;
 export type DeliveryReason = (typeof DELIVERY_REASONS)[number];
 
 export type BriefingDeliveryResult = {

services/kiloclaw/src/durable-objects/gateway-controller-types.ts

@@ -1,4 +1,9 @@
 import { z, type ZodType } from 'zod';
+import {
+  DELIVERY_CHANNELS,
+  DELIVERY_REASONS,
+  DELIVERY_STATUSES,
+} from '../../plugins/kiloclaw-morning-briefing/src/delivery-constants';
 
 export type GatewayProcessStatus = {
   state: 'stopped' | 'starting' | 'running' | 'stopping' | 'crashed' | 'shutting_down';
@@ -104,15 +109,6 @@ const MorningBriefingSourceReadinessSchema = z.object({
   summary: z.string(),
 });
 
-const DELIVERY_CHANNELS = ['telegram', 'discord', 'slack'] as const;
-const DELIVERY_STATUSES = ['sent', 'skipped', 'failed'] as const;
-const DELIVERY_REASONS = [
-  'missing_target',
-  'ambiguous_target',
-  'send_failed',
-  'config_unavailable',
-] as const;
-
 const MorningBriefingDeliverySchema = z.object({
   channel: z.enum(DELIVERY_CHANNELS),
   status: z.enum(DELIVERY_STATUSES),