feat(cloud-agent-next): filter health dashboard by platform

eshurakov · eshurakov · commit fd1d0cd09dcf · 2026-05-28T14:41:34.000+02:00
diff --git a/apps/web/src/app/admin/api/cloud-agent-next/hooks.ts b/apps/web/src/app/admin/api/cloud-agent-next/hooks.ts
@@ -12,6 +12,7 @@ export type CloudAgentNextFilters = {
 
 export type CloudAgentNextHealthFilters = CloudAgentNextFilters & {
   bucket: 'hour' | 'day';
+  createdOnPlatform?: string | null;
 };
 
 export type CloudAgentNextHealthError = {
@@ -36,6 +37,11 @@ function enabledForInterval(params: CloudAgentNextFilters) {
   return Boolean(params.startDate && params.endDate);
 }
 
+export function useCloudAgentNextHealthPlatforms() {
+  const trpc = useTRPC();
+  return useQuery(trpc.admin.cloudAgentNext.listHealthPlatforms.queryOptions());
+}
+
 export function useCloudAgentNextHealthOverview(
   params: CloudAgentNextHealthFilters,
   enabled = true
@@ -59,6 +65,7 @@ export function useCloudAgentNextHealthErrorSessions(
       source: error?.source ?? 'run',
       stage: error?.stage ?? 'not-selected',
       code: error?.code ?? 'not-selected',
+      createdOnPlatform: params.createdOnPlatform,
     }),
     enabled: enabledForInterval(params) && Boolean(error),
   });
diff --git a/apps/web/src/app/admin/components/CloudAgentNextTelemetry/CloudAgentNextOutcomesPage.tsx b/apps/web/src/app/admin/components/CloudAgentNextTelemetry/CloudAgentNextOutcomesPage.tsx
@@ -16,6 +16,7 @@ import AdminPage from '@/app/admin/components/AdminPage';
 import {
   useCloudAgentNextHealthErrorSessions,
   useCloudAgentNextHealthOverview,
+  useCloudAgentNextHealthPlatforms,
   type CloudAgentNextHealthFilters,
 } from '@/app/admin/api/cloud-agent-next/hooks';
 import { CopyButton } from '@/components/admin/CopyButton';
@@ -88,6 +89,23 @@ type TopError = HealthData['topErrors'][number];
 type TooltipPayload = { payload: SeriesPoint };
 
 const DEFAULT_RANGE: RangeValue = DEFAULT_HEALTH_PERIOD;
+const ALL_PLATFORMS_VALUE = 'all-platforms';
+const UNKNOWN_PLATFORM_VALUE = 'unknown-platform';
+const EXACT_PLATFORM_PREFIX = 'platform:';
+
+function platformSelectionValue(platform: string): string {
+  return `${EXACT_PLATFORM_PREFIX}${platform}`;
+}
+
+function createdOnPlatformForSelection(selection: string): string | null | undefined {
+  if (selection === ALL_PLATFORMS_VALUE) return undefined;
+  if (selection === UNKNOWN_PLATFORM_VALUE) return null;
+  if (selection.startsWith(EXACT_PLATFORM_PREFIX)) {
+    return selection.slice(EXACT_PLATFORM_PREFIX.length);
+  }
+  return undefined;
+}
+
 const utcLongLabel = new Intl.DateTimeFormat('en-US', {
   timeZone: 'UTC',
   month: 'short',
@@ -107,15 +125,20 @@ const utcShortDay = new Intl.DateTimeFormat('en-US', {
   day: 'numeric',
 });
 
-function intervalForRange(range: RangeValue): CloudAgentNextHealthFilters {
+function intervalForRange(
+  range: RangeValue,
+  platformSelection = ALL_PLATFORMS_VALUE
+): CloudAgentNextHealthFilters {
   const selectedRange = RANGE_OPTIONS.find(option => option.value === range) ?? RANGE_OPTIONS[3];
+  const createdOnPlatform = createdOnPlatformForSelection(platformSelection);
   const end = new Date();
   if (selectedRange.bucket === 'day') end.setUTCHours(0, 0, 0, 0);
   else end.setUTCMinutes(0, 0, 0);
   return {
     startDate: new Date(end.getTime() - selectedRange.durationMs).toISOString(),
     endDate: end.toISOString(),
     bucket: selectedRange.bucket,
+    ...(createdOnPlatform === undefined ? {} : { createdOnPlatform }),
   };
 }
 
@@ -565,8 +588,10 @@ function TopErrors({
 
 export default function CloudAgentNextOutcomesPage() {
   const [range, setRange] = useState<RangeValue>(DEFAULT_RANGE);
+  const [platformSelection, setPlatformSelection] = useState(ALL_PLATFORMS_VALUE);
   const [interval, setInterval] = useState(() => intervalForRange(DEFAULT_RANGE));
   const [hasLoadedPeriodPreference, setHasLoadedPeriodPreference] = useState(false);
+  const healthPlatforms = useCloudAgentNextHealthPlatforms();
   const health = useCloudAgentNextHealthOverview(interval, hasLoadedPeriodPreference);
   const bucket = interval.bucket;
 
@@ -583,15 +608,21 @@ export default function CloudAgentNextOutcomesPage() {
     if (!isHealthPeriod(value)) return;
     setStoredHealthPeriod(value);
     setRange(value);
-    setInterval(intervalForRange(value));
+    setInterval(intervalForRange(value, platformSelection));
+  }
+
+  function updatePlatformSelection(value: string) {
+    setPlatformSelection(value);
+    setInterval(intervalForRange(range, value));
   }
 
   function refresh() {
-    const nextInterval = intervalForRange(range);
+    const nextInterval = intervalForRange(range, platformSelection);
     if (
       nextInterval.startDate === interval.startDate &&
       nextInterval.endDate === interval.endDate &&
-      nextInterval.bucket === interval.bucket
+      nextInterval.bucket === interval.bucket &&
+      nextInterval.createdOnPlatform === interval.createdOnPlatform
     ) {
       void health.refetch();
       return;
@@ -620,20 +651,49 @@ export default function CloudAgentNextOutcomesPage() {
               Operational outcome trends from best-effort Cloud Agent reporting.
             </p>
           </div>
-          <div className="flex min-w-60 flex-col gap-2">
-            <Label htmlFor="cloud-agent-health-period">Period</Label>
-            <Select value={range} onValueChange={updateRange}>
-              <SelectTrigger id="cloud-agent-health-period" className="w-full">
-                <SelectValue />
-              </SelectTrigger>
-              <SelectContent>
-                {RANGE_OPTIONS.map(option => (
-                  <SelectItem key={option.value} value={option.value}>
-                    {option.label}
-                  </SelectItem>
-                ))}
-              </SelectContent>
-            </Select>
+          <div className="grid w-full gap-3 sm:grid-cols-2 md:w-auto md:min-w-[32rem]">
+            <div className="flex flex-col gap-2">
+              <Label htmlFor="cloud-agent-health-period">Period</Label>
+              <Select value={range} onValueChange={updateRange}>
+                <SelectTrigger id="cloud-agent-health-period" className="w-full">
+                  <SelectValue />
+                </SelectTrigger>
+                <SelectContent>
+                  {RANGE_OPTIONS.map(option => (
+                    <SelectItem key={option.value} value={option.value}>
+                      {option.label}
+                    </SelectItem>
+                  ))}
+                </SelectContent>
+              </Select>
+            </div>
+            <div className="flex flex-col gap-2">
+              <Label htmlFor="cloud-agent-health-platform">Created on platform</Label>
+              <Select value={platformSelection} onValueChange={updatePlatformSelection}>
+                <SelectTrigger id="cloud-agent-health-platform" className="w-full">
+                  <SelectValue />
+                </SelectTrigger>
+                <SelectContent>
+                  <SelectItem value={ALL_PLATFORMS_VALUE}>All platforms</SelectItem>
+                  {healthPlatforms.isLoading && (
+                    <SelectItem value="loading-platforms" disabled>
+                      Loading platforms...
+                    </SelectItem>
+                  )}
+                  {healthPlatforms.error && (
+                    <SelectItem value="platforms-unavailable" disabled>
+                      Platforms unavailable
+                    </SelectItem>
+                  )}
+                  {healthPlatforms.data?.map(platform => (
+                    <SelectItem key={platform} value={platformSelectionValue(platform)}>
+                      <span className="font-mono text-xs">{platform}</span>
+                    </SelectItem>
+                  ))}
+                  <SelectItem value={UNKNOWN_PLATFORM_VALUE}>Unknown / unlinked</SelectItem>
+                </SelectContent>
+              </Select>
+            </div>
           </div>
         </div>
         <p className="text-muted-foreground text-xs">
diff --git a/apps/web/src/routers/admin-cloud-agent-next-router.test.ts b/apps/web/src/routers/admin-cloud-agent-next-router.test.ts
@@ -87,12 +87,20 @@ describe('adminCloudAgentNextRouter', () => {
         created_at: '2025-01-10T00:20:00.000Z',
       },
     ]);
-    await db.insert(cli_sessions_v2).values({
-      session_id: 'ses_admin_outcomes_mapped',
-      kilo_user_id: adminUser.id,
-      cloud_agent_session_id: ids.mapped,
-      created_on_platform: 'vscode',
-    });
+    await db.insert(cli_sessions_v2).values([
+      {
+        session_id: 'ses_admin_outcomes_mapped',
+        kilo_user_id: adminUser.id,
+        cloud_agent_session_id: ids.mapped,
+        created_on_platform: 'vscode',
+      },
+      {
+        session_id: 'ses_admin_setup_failed_later',
+        kilo_user_id: adminUser.id,
+        cloud_agent_session_id: ids.setupFailedLater,
+        created_on_platform: ' code-review ',
+      },
+    ]);
     await db.insert(cloud_agent_session_runs).values([
       {
         cloud_agent_session_id: ids.mapped,
@@ -290,6 +298,79 @@ describe('adminCloudAgentNextRouter', () => {
     expect(JSON.stringify(health.topErrors)).not.toContain('wrapper_start_failed');
   });
 
+  it('filters health and error drilldowns by exact or unknown created platform', async () => {
+    const caller = await createCallerForUser(adminUser.id);
+    const platforms = await caller.admin.cloudAgentNext.listHealthPlatforms();
+    const vscodeHealth = await caller.admin.cloudAgentNext.getHealthOverview({
+      ...interval(),
+      bucket: 'hour',
+      createdOnPlatform: 'vscode',
+    });
+    const legacyRawPlatformHealth = await caller.admin.cloudAgentNext.getHealthOverview({
+      ...interval(),
+      bucket: 'hour',
+      createdOnPlatform: ' code-review ',
+    });
+    await db
+      .update(cli_sessions_v2)
+      .set({ created_on_platform: 'unknown' })
+      .where(eq(cli_sessions_v2.cloud_agent_session_id, ids.setupFailedLater));
+    const platformsAfterStoredUnknown = await caller.admin.cloudAgentNext.listHealthPlatforms();
+    const unknownHealth = await caller.admin.cloudAgentNext.getHealthOverview({
+      ...interval(),
+      bucket: 'hour',
+      createdOnPlatform: null,
+    });
+    const vscodeRunSessions = await caller.admin.cloudAgentNext.listHealthErrorSessions({
+      ...interval(),
+      source: 'run',
+      stage: 'pre_dispatch',
+      code: 'workspace_setup_failed',
+      createdOnPlatform: 'vscode',
+    });
+    const unknownSetupSessions = await caller.admin.cloudAgentNext.listHealthErrorSessions({
+      ...interval(),
+      source: 'setup',
+      stage: 'initial_admission',
+      code: 'initial_admission_rejected',
+      createdOnPlatform: null,
+    });
+
+    expect(platforms).toEqual([' code-review ', 'vscode']);
+    expect(platformsAfterStoredUnknown).toEqual(['vscode']);
+    expect(vscodeHealth.summary).toEqual({
+      completedRuns: 1,
+      failedRuns: 1,
+      interruptedRuns: 0,
+      setupFailures: 0,
+    });
+    expect(vscodeHealth.topErrors).toEqual([
+      { source: 'run', stage: 'pre_dispatch', code: 'workspace_setup_failed', count: 1 },
+    ]);
+    expect(legacyRawPlatformHealth.summary).toEqual({
+      completedRuns: 0,
+      failedRuns: 0,
+      interruptedRuns: 0,
+      setupFailures: 1,
+    });
+    expect(unknownHealth.summary).toEqual({
+      completedRuns: 0,
+      failedRuns: 1,
+      interruptedRuns: 1,
+      setupFailures: 2,
+    });
+    expect(vscodeRunSessions.rows).toEqual([
+      expect.objectContaining({ cloudAgentSessionId: ids.mapped }),
+    ]);
+    expect(unknownSetupSessions).toMatchObject({ totalSessions: 2 });
+    expect(unknownSetupSessions.rows).toEqual(
+      expect.arrayContaining([
+        expect.objectContaining({ cloudAgentSessionId: ids.setupFailed }),
+        expect.objectContaining({ cloudAgentSessionId: ids.setupFailedLater }),
+      ])
+    );
+  });
+
   it('summarizes longer health ranges into daily UTC buckets', async () => {
     const caller = await createCallerForUser(adminUser.id);
     const health = await caller.admin.cloudAgentNext.getHealthOverview({
diff --git a/apps/web/src/routers/admin-cloud-agent-next-router.ts b/apps/web/src/routers/admin-cloud-agent-next-router.ts
