Skip to content

ci(vercel): delegate app deploys to vercel#2796

Open
RSO wants to merge 1 commit intomainfrom
RSO/cumbersome-parrotfish
Open

ci(vercel): delegate app deploys to vercel#2796
RSO wants to merge 1 commit intomainfrom
RSO/cumbersome-parrotfish

Conversation

@RSO
Copy link
Copy Markdown
Contributor

@RSO RSO commented Apr 24, 2026

Summary

  • Remove GitHub Actions Vercel CLI builds and deploys so kilocode-app and kilocode-global-app can deploy through Vercel Git Integration.
    • Allows us to redeploy from Vercel (helpful when changing ENV variables)
    • Allows us to switch to sensitive ENV variables in Vercel
  • Stop pulling Vercel environment files in GitHub Actions so Vercel secrets can be marked sensitive.
  • Keep production migrations in GitHub Actions using explicit migration secrets and preserve KiloClaw deploy routing.

Verification

  • Probably want to see that tests work
  • Need to enable git integration with a "wait for tests to complete" check

Reviewer Notes

  • Add POSTGRES_MIGRATION_URL to the GitHub production environment before merging.
  • Add DATABASE_CA to the GitHub production environment too if production Postgres requires it.
  • Configure Vercel Deployment Checks for both app projects to require Deploy to Production / run-migrations before production aliasing.
  • Vercel will still build before checks complete; Deployment Checks gate production promotion/aliasing.

@RSO RSO changed the title ci(vercel): delegate app deploys to git integration ci(vercel): delegate app deploys to verce Apr 24, 2026
@RSO RSO changed the title ci(vercel): delegate app deploys to verce ci(vercel): delegate app deploys to vercel Apr 24, 2026
NODE_ENV: production
POSTGRES_URL: ${{ secrets.POSTGRES_MIGRATION_URL }}
DATABASE_CA: ${{ secrets.DATABASE_CA }}
run: pnpm run drizzle migrate
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Production promotion is no longer serialized behind migrations

Once the deploy-app and deploy-global-app jobs are removed, this workflow stops providing any in-repo ordering between a main push and the Vercel production rollout. Unless both Vercel projects already have a deployment check wired to Deploy to Production / run-migrations, schema-dependent app code can be promoted before this job finishes and start reading the old database shape.

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented Apr 24, 2026

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0

Fix these issues in Kilo Cloud

Issue Details (click to expand)

WARNING

File Line Issue
.github/workflows/deploy-production.yml 43 Production rollout is no longer serialized behind migrations unless Vercel deployment checks are already configured.
Other Observations (not in diff)

No additional issues found outside the diff.

Files Reviewed (2 files)
  • .github/workflows/ci.yml - 0 issues
  • .github/workflows/deploy-production.yml - 1 issue

Reviewed by gpt-5.4-20260305 · 579,419 tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant