Skip to content

fix(bot): open separate prs from comments#3557

Closed
alex-alecu wants to merge 2 commits into
mainfrom
feat/enable-kilobot-to-create-pr
Closed

fix(bot): open separate prs from comments#3557
alex-alecu wants to merge 2 commits into
mainfrom
feat/enable-kilobot-to-create-pr

Conversation

@alex-alecu
Copy link
Copy Markdown
Contributor

Summary

  • Detect when a GitHub PR comment clearly asks Kilo Bot to open a separate new PR.
  • Start Cloud Agent with instructions to use a fresh branch from the original PR base and not change the current PR branch.
  • Keep normal mentions and negated requests working the same as before.

Verification

N/A. No manual GitHub webhook run was performed.

Visual Changes

N/A

Reviewer Notes

The new behavior is limited to GitHub PR contexts and explicit, non-negated requests for a new or separate PR.

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented May 28, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Clean refactor that replaces client-side regex-based separate-PR detection with LLM-driven githubPullRequestStrategy schema field, adds a new current_pr_branch strategy instruction, and removes all the now-unnecessary pr-creation-strategy module and passthrough wiring — no bugs, security issues, or logic errors found.

Files Reviewed (5 files)
  • apps/web/src/lib/bot/tools/spawn-cloud-agent-session.ts — new githubPullRequestStrategy field and CURRENT_PULL_REQUEST_BRANCH_STRATEGY_INSTRUCTION constant correct; strategy gating on githubRepo intact
  • apps/web/src/lib/bot/tools/spawn-cloud-agent-session.test.ts — new test for current_pr_branch path added; separate_pull_request test updated to use schema field; no-op test present
  • apps/web/src/lib/bot/agent-runner.tsuseSeparatePullRequestStrategy option removed cleanly; LLM tool description updated correctly
  • apps/web/src/lib/bot/run.tsshouldUseSeparatePullRequestStrategy call removed correctly
  • apps/web/src/lib/bot/pr-creation-strategy.ts / .test.ts — deleted; no remaining references

Reviewed by claude-4.6-sonnet-20260217 · 249,841 tokens

Review guidance: REVIEW.md from base branch main

@alex-alecu
Copy link
Copy Markdown
Contributor Author

@kilocode-bot Open a new PR with a single change on root REVIEW.md file for this repo in which you add a single line instructing the use at max of sub-agents.

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented May 28, 2026

Done! A new PR has been created: #3567

It adds a line about using at most sub-agents in REVIEW.md, on a fresh branch off main.

@alex-alecu
Copy link
Copy Markdown
Contributor Author

This PR is not necessary, it already works. Example in this PR + in thread #3558 (comment)

@alex-alecu alex-alecu closed this May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant