Skip to content

Dev - Isolate Wrangler Registry Per Worktree#3578

Merged
eshurakov merged 1 commit into
mainfrom
magenta-nail
May 29, 2026
Merged

Dev - Isolate Wrangler Registry Per Worktree#3578
eshurakov merged 1 commit into
mainfrom
magenta-nail

Conversation

@eshurakov
Copy link
Copy Markdown
Contributor

Summary

  • Isolate Wrangler local service discovery per worktree by passing .wrangler/dev-registry through each dev:start tmux session.
  • Record the selected registry path in the dev manifest and add regression coverage for worktree-local path derivation.
  • Document concurrent offset Agent stacks while retaining shared infrastructure and existing dev:stop behavior.

Verification

Not manually exercised; the behavior requires simultaneous local stacks in separate worktrees.

Visual Changes

N/A

Reviewer Notes

WRANGLER_REGISTRY_PATH is supported by the pinned Wrangler version but is not documented as a public Cloudflare environment variable.

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented May 28, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Clean, minimal change that correctly scopes the Wrangler service-discovery registry per worktree by deriving the path from repoRoot and injecting it as WRANGLER_REGISTRY_PATH into each tmux session, with adequate regression test coverage and updated documentation.

Files Reviewed (4 files)
  • dev/local/wrangler-registry.ts — new helper, correct path.resolve usage
  • dev/local/wrangler-registry.test.ts — two correct test cases covering absolute path and basename-collision cases
  • dev/local/cli.tsWRANGLER_REGISTRY_PATH injected into tmux session env and manifest consistently
  • DEVELOPMENT.md — documentation accurate and consistent with implementation

Fix these issues in Kilo Cloud


Reviewed by claude-sonnet-4.6 · 371,229 tokens

Review guidance: REVIEW.md from base branch main

@eshurakov eshurakov merged commit 9b0bba3 into main May 29, 2026
14 checks passed
@eshurakov eshurakov deleted the magenta-nail branch May 29, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants