Skip to content

fix(session-ingest): delay queue retries safely#3702

Merged
johnnyeric merged 2 commits into
mainfrom
johnnyeric/session-ingest-retry-delay-ordering
Jun 3, 2026
Merged

fix(session-ingest): delay queue retries safely#3702
johnnyeric merged 2 commits into
mainfrom
johnnyeric/session-ingest-retry-delay-ordering

Conversation

@johnnyeric
Copy link
Copy Markdown
Contributor

Summary

  • Add a 60s delay before retrying failed session-ingest queue messages to reduce immediate pressure on hot Durable Objects.
  • Preserve session serving order under delayed retries by scanning persisted messages/parts by ingested_at with SQLite id as a tie-breaker.
  • Keep metrics ordering aligned with ingest time rather than delayed processing/insertion order.

Validation

  • pnpm --filter cloudflare-session-ingest exec vitest run src/queue-consumer.test.ts src/dos/SessionIngestDO.test.ts src/dos/session-ingest-history-budget.test.ts
  • pnpm --filter cloudflare-session-ingest typecheck
  • scripts/lint-all.sh

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented Jun 3, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental review (new commits since 41be1d8) confirms the previously-noted non-blocking concern has been addressed: a composite index (ingested_at, id) is now created via a new Drizzle migration (0002_watery_venus.sql) and declared in sqlite-schema.ts, aligning the cursor-based scan with proper index coverage. No new issues found.

Files Reviewed (5 files — incremental)
  • services/session-ingest/drizzle/0002_watery_venus.sql ✓ (generated migration — index correct)
  • services/session-ingest/drizzle/meta/0002_snapshot.json ✓ (generated snapshot)
  • services/session-ingest/drizzle/meta/_journal.json ✓ (generated journal entry)
  • services/session-ingest/drizzle/migrations.js ✓ (migration registered)
  • services/session-ingest/src/db/sqlite-schema.ts ✓ (index declaration matches migration)

Previously reviewed (unchanged):

  • services/session-ingest/src/dos/SessionIngestDO.ts
  • services/session-ingest/src/dos/SessionIngestDO.test.ts
  • services/session-ingest/src/queue-consumer.ts
  • services/session-ingest/src/queue-consumer.test.ts

Reviewed by claude-4.6-sonnet-20260217 · 228,526 tokens

Review guidance: REVIEW.md from base branch main

@johnnyeric johnnyeric force-pushed the johnnyeric/session-ingest-retry-delay-ordering branch from b272842 to 41facd2 Compare June 3, 2026 14:27
@johnnyeric johnnyeric force-pushed the johnnyeric/session-ingest-retry-delay-ordering branch from 41facd2 to 41be1d8 Compare June 3, 2026 14:31
Copy link
Copy Markdown
Contributor

@iscekic iscekic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One finding from review.

Comment thread services/session-ingest/src/dos/SessionIngestDO.ts
@johnnyeric johnnyeric merged commit 34fce77 into main Jun 3, 2026
16 checks passed
@johnnyeric johnnyeric deleted the johnnyeric/session-ingest-retry-delay-ordering branch June 3, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants