fix(review): use configured model for fix sessions#4091
Open
alex-alecu wants to merge 1 commit into
Open
Conversation
Resolve the owner catalog model before preparing a review fix session so usage-resolved model IDs are not rejected.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryReviewed the fix-session model-resolution change in the Cloud Agent review route and its tests; the logic is sound, both tRPC caller paths resolve correctly, and the new failure-path coverage is adequate. Files Reviewed (2 files)
Notes
Reviewed by glm-5.2-20260616 · 993,772 tokens Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
N/A — no manual production flow was executed because it requires an authenticated Code Review fix link.
Visual Changes
N/A
Reviewer Notes
Fix sessions intentionally use the owner's current Code Review model configuration when the link is clicked. The historical
cloud_agent_code_reviews.modelfield remains dedicated to reporting the concrete model recorded by usage billing.