fix(vscode): deduplicate fatal autocomplete notification for next-edit provider#11569
Open
markijbema wants to merge 5 commits into
Open
fix(vscode): deduplicate fatal autocomplete notification for next-edit provider#11569markijbema wants to merge 5 commits into
markijbema wants to merge 5 commits into
Conversation
…t provider Mirror the FIM path's pause/notify semantics in NextEditInlineCompletionProvider: - Add ErrorBackoff instance and fatalNotified flag to gate repeated notifications - Block all requests once a fatal (401/402) is recorded via backoff.blocked() - Only call onFatalError once per fatal episode via fatalNotified guard - Add resetBackoff() method cleared on auth/connection state changes - Call nextEditProvider.resetBackoff() alongside classic provider in AutocompleteServiceManager Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous Review Summaries (2 snapshots, latest commit f3ec065)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit f3ec065)Status: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous review (commit 8acd647)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Fix these issues in Kilo Cloud Files Reviewed (3 files)
Reviewed by gpt-5.4-20260305 · Input: 94.9K · Output: 7.4K · Cached: 490K Review guidance: REVIEW.md from base branch |
Bring NextEditInlineCompletionProvider to full parity with the FIM path: - On a successful (non-throwing) Mercury response, call backoff.success() and clear fatalNotified so each fatal episode notifies exactly once. - When blocked by a 402, periodically probe the balance endpoint (hasBalance) and resume autocomplete if the user topped up, instead of waiting for an auth/reconnect event. Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Both the FIM and next-edit providers hand-rolled the same pause/notify/recover state machine around ErrorBackoff (blocked-gate + 402 balance probe, notify-once latch, reset-on-success, hasBalance). Extract that orchestration into a single BackoffGate so the two providers can't drift apart again — the exact divergence that let next-edit spam the paused notification. No behavior change. Co-authored-by: kiloconnect[bot] <240665456+kiloconnect[bot]@users.noreply.github.com>
Contributor
Author
|
Refactored to remove the duplication: the pause/notify/recover state machine that both providers were hand-rolling (blocked-gate + 402 balance probe, notify-once latch, reset-on-success, |
NJ-2020
pushed a commit
to NJ-2020/kilocode
that referenced
this pull request
Jul 4, 2026
…hout errors, fix issue with reasoning opaque not being picked up for gemini models (Kilo-Org#11569)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the bug where the "Kilo Code autocomplete has been paused" notification fires on every keystroke when the Inception next-edit provider is configured and the user is not logged in. Brings the next-edit provider to full parity with the classic FIM pause/recover behavior.
Why
NextEditInlineCompletionProvider.handleError()had no circuit breaker: every 401/402 response firedonFatalError, popping the toast again. The classic FIM path already handles this correctly viaErrorBackoff+ afatalNotifiedguard + a 402 balance probe.Changes
NextEditInlineCompletionProvider:ErrorBackoffinstance and afatalNotifiedflag.provideInlineCompletionItemsreturns[]immediately whenbackoff.blocked()(no network request). When blocked on a 402, it periodically probes the balance endpoint (hasBalance()) and resumes if the user topped up — matching FIM's self-heal.backoff.success()and clearsfatalNotified, so each fatal episode notifies exactly once.handleErrorcallsbackoff.failure(err)and only invokesonFatalErroronce per fatal episode.resetBackoff()clears bothbackoffandfatalNotified.AutocompleteServiceManager:nextEditProvider.resetBackoff()alongsideinlineCompletionProvider.resetBackoff()in both theonStateChangeandglobal.disposedhandlers, so a re-auth or reconnect (e.g. login) unblocks the next-edit path too.Behavior after this change (consistent with FIM)
global.disposed/ a connection state change, which resets the backoff).