fix(agent-manager): color PR badge by state, show checks as icon#11785
Merged
Conversation
markijbema
approved these changes
Jun 29, 2026
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| > | ||
| <Icon name={pr().review === "approved" ? "check-small" : "branch"} size="small" /> | ||
| <span class="am-pr-badge" style={{ "--pr-accent": accent() }} onClick={handleOpenPR}> | ||
| <Switch fallback={<Icon name="branch" size="small" />}> |
Contributor
There was a problem hiding this comment.
WARNING: Terminal PRs still render a status icon
prBadgeIndicator() returns "none" for merged and closed PRs, but this Switch falls back to the neutral branch icon. That means terminal badges still render a leading glyph even though the new contract says merged/closed PRs should show no status icon. Consider handling "none" explicitly and rendering nothing for that case.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
| <div style={{ "max-height": "560px", overflow: "auto" }}> | ||
| <DndWrap> | ||
| <SectionHeader section={sec("s1", 0, { name: "In Review", color: "Blue" })} count={3} {...sectionProps}> | ||
| <SectionHeader section={sec("s1", 0, { name: "In Review", color: "Blue" })} count={8} {...sectionProps}> |
Contributor
There was a problem hiding this comment.
SUGGESTION: Story count no longer matches the rendered badge states
This header count was changed to 8, but the story below renders seven WorktreeItems and the PR description also describes seven states. Leaving it at 8 makes the visual-regression fixture and generated screenshot show a mismatched section count.
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Contributor
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (5 files)
Previous Review Summaries (2 snapshots, latest commit f9a977d)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit f9a977d)Status: 2 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (5 files)
Previous review (commit 9993f99)Status: 2 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (5 files)
Reviewed by gpt-5.4-2026-03-05 · Input: 44.5K · Output: 3.9K · Cached: 103.9K Review guidance: REVIEW.md from base branch |
Badge color now reflects only the PR lifecycle state (open/draft/merged/closed), so a failing check is no longer mistaken for a closed PR. CI and review results are shown as a separate icon (failing checks, changes requested, approved), and an open PR whose checks are still running keeps its pulsing amber badge.
marius-kilocode
force-pushed
the
bead-apogee
branch
from
9993f99 to
5e22a7b
Compare
vkeerthivikram
pushed a commit
to vkeerthivikram/kilocode
that referenced
this pull request
Jun 30, 2026
fix(agent-manager): color PR badge by state, show checks as icon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In Agent Manager, the PR badge on each worktree card uses color to encode several unrelated signals at once. A merged PR is purple, an open PR is green, a closed PR is red, but a failing CI check also turns the badge red. Because red is established as the "closed" color, a card with failing tests reads as a closed PR. The PR's lifecycle state and its CI status are two independent things being collapsed onto one color channel.
Change
Split the signals so the badge color means one thing and CI/review status is shown separately:
✗(circle-x)A failing open PR is now a green badge with a red ✗, clearly distinct from a red closed-PR badge. Terminal states (merged/closed) show no status icon since their checks are no longer actionable.
This is the focused color/icon fix. Surfacing full PR checks, comments, and merge actions inside Agent Manager is a larger, separate effort and is not part of this change.
Screenshots / tests
The
WithPRBadgesvisual-regression story renders all states in one card list (open passing/approved, open failing, open changes-requested, open checks-running, draft, merged, closed) so the colors and icons are captured side by side. CI generates the baseline PNG (animations are disabled in snapshots, so the running-checks badge appears as a static amber badge).