ci: resolve draft release assets via API in smoke-test#9160
Merged
lambertjosh merged 3 commits intomainfrom Apr 20, 2026
Merged
ci: resolve draft release assets via API in smoke-test#9160lambertjosh merged 3 commits intomainfrom
lambertjosh merged 3 commits intomainfrom
Conversation
Fixes Kilo CLI install failing with curl exit 22 when the smoke-test workflow runs as a pre-publish gate. The browser download URL (github.com/.../releases/download/...) 404s on draft releases, so look up the asset via the releases API and let the installer use the API URL with Accept: application/octet-stream and bearer auth. Also bumps smoke-test.yml permissions to contents: write so the job token can see draft releases, and re-enables the smoke-test job in publish.yml.
Contributor
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
Files Reviewed (1 files)
Reviewed by gpt-5.4-20260305 · 196,786 tokens |
AI Code Trust — ship readinessScore: 100 · Verdict: SAFE · Model: deterministic-v1 No blocking issues detected by automated checks. |
Addresses review feedback: `gh api | head -n1` can fail under bash pipefail because head closes the pipe early and SIGPIPEs gh api. The tag_name + asset-name filter already returns a single URL, so drop --paginate and the head pipe.
Contributor
Author
|
I tested this against a draft release, 7.2.13 which was a failed full publish from Friday, and confirmed this works: https://github.com/Kilo-Org/kilocode/actions/runs/24617231981/job/71981389992. |
Contributor
Author
|
@catrielmuller - can you review, this works now, I tested with an draft release from the a failed publish on Friday. (7.2.13). https://github.com/Kilo-Org/kilocode/actions/runs/24617231981/job/71981389992 |
catrielmuller
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the smoke-test install failure (curl exit 22) when run as a pre-publish gate. Browser
releases/download/...URLs 404 on draft releases, so look up the asset via the API instead. Also bumps permissions tocontents: writeso the token can see drafts, and re-enables the job in publish.yml.