Skip to content

ci: resolve draft release assets via API in smoke-test#9160

Merged
lambertjosh merged 3 commits intomainfrom
fix/smoke-test-draft-release
Apr 20, 2026
Merged

ci: resolve draft release assets via API in smoke-test#9160
lambertjosh merged 3 commits intomainfrom
fix/smoke-test-draft-release

Conversation

@lambertjosh
Copy link
Copy Markdown
Contributor

Fixes the smoke-test install failure (curl exit 22) when run as a pre-publish gate. Browser releases/download/... URLs 404 on draft releases, so look up the asset via the API instead. Also bumps permissions to contents: write so the token can see drafts, and re-enables the job in publish.yml.

Fixes Kilo CLI install failing with curl exit 22 when the smoke-test
workflow runs as a pre-publish gate. The browser download URL
(github.com/.../releases/download/...) 404s on draft releases, so
look up the asset via the releases API and let the installer use the
API URL with Accept: application/octet-stream and bearer auth.

Also bumps smoke-test.yml permissions to contents: write so the job
token can see draft releases, and re-enables the smoke-test job in
publish.yml.
Comment thread .github/workflows/smoke-test.yml Outdated
@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented Apr 18, 2026

Code Review Summary

Status: 1 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0

Fix these issues in Kilo Cloud

Issue Details (click to expand)

WARNING

File Line Issue
.github/workflows/smoke-test.yml 97 Removing --paginate means manual smoke tests can no longer resolve releases older than GitHub's first results page.
Files Reviewed (1 files)
  • .github/workflows/smoke-test.yml - 1 issue

Reviewed by gpt-5.4-20260305 · 196,786 tokens

@nehaaprasad
Copy link
Copy Markdown

AI Code Trust — ship readiness

Score: 100 · Verdict: SAFE · Model: deterministic-v1

No blocking issues detected by automated checks.

Addresses review feedback: `gh api | head -n1` can fail under bash
pipefail because head closes the pipe early and SIGPIPEs gh api. The
tag_name + asset-name filter already returns a single URL, so drop
--paginate and the head pipe.
Comment thread .github/workflows/smoke-test.yml
@lambertjosh
Copy link
Copy Markdown
Contributor Author

I tested this against a draft release, 7.2.13 which was a failed full publish from Friday, and confirmed this works: https://github.com/Kilo-Org/kilocode/actions/runs/24617231981/job/71981389992.

@lambertjosh
Copy link
Copy Markdown
Contributor Author

@catrielmuller - can you review, this works now, I tested with an draft release from the a failed publish on Friday. (7.2.13). https://github.com/Kilo-Org/kilocode/actions/runs/24617231981/job/71981389992

@lambertjosh lambertjosh merged commit 08a21d7 into main Apr 20, 2026
13 checks passed
@lambertjosh lambertjosh deleted the fix/smoke-test-draft-release branch April 20, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants