Merged
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by gpt-5.4-20260305 · 82,254 tokens |
RSO
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guards the three
"Registered …"info lines inregister()behind a module-scopedregistrationLoggedflag so they fire at most once per process. Without this guard OpenClaw's plugin loader re-invokesregister(api)once per distinctloadOpenClawPluginscacheKey (gateway startup, provider discovery, metadata registry, web-fetch/web-search runtimes, etc.), producing ~44 redundant log lines per KiloClaw boot.Background
Investigation traced the log spam to
openclaw/src/plugins/loader.ts:loadOpenClawPlugins, which is called from many distinct code paths (gateway startup, CLI metadata, provider discovery, web-fetch/web-search runtimes, metadata-registry-loader, status, etc.). Each call with a differentcacheKeybuilds a fresh registry and invokes every plugin'sregister(api)again. Our three unconditionalapi.logger.info?.(...)calls therefore fired ~15 times per process.The plugin's tool factory (
(toolCtx) => ({...})) re-running per tool-collection event was a known, documented behavior — but the threeinfolines were in the outerregister(), not in the factory, so that context was misleading.Scope
api.registerTool(...)andapi.registerCommand(...)still run on everyregister()call — intentional, because eachloadOpenClawPluginspass builds its own registry and the plugin must register into every one to be visible in that context.Changes
index.ts: added module-scopedlet registrationLogged = falseand wrapped the three info log calls in a first-time guard. Comment explains whyregister()runs multiple times and why only logging is gated.CHANGELOG.md:[Unreleased] → Fixedentry describing the spam root cause and the guard.Test plan
bun run typecheck— passesbun run format:check(on edited files) — passesbun test— 54/54 pass