Skip to content

Add Password field to server-dest.conf #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kimahari wants to merge 1 commit into from
Closed

Add Password field to server-dest.conf #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions server-dest.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"ServerInstance": ".\\SQLExpress",
"UserName": null
}
"UserName": null,
"Password" : null
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Persist and load destination password from config

Adding Password in server-dest.conf implies this value is usable, but MainViewModel only reads/writes ServerInstance and UserName (ViewModels/MainViewModel.cs:157-159 and 184-186), so this key is ignored and removed on the next save. If a user sets UserName in config and expects this new Password field to be applied, DestinationConnection.Password stays null and BuildConnection dereferences it at Models/ConnectionModel.cs:126, which can fail at runtime instead of using the configured credential.

Useful? React with 👍 / 👎.

}