Skip to content

Commit 61644ac

Browse files
committed
add DevTools::isButtonEnabled instead of using GEODE_DESKTOP everywhere
1 parent 3bd831a commit 61644ac

4 files changed

Lines changed: 14 additions & 7 deletions

File tree

src/DevTools.cpp

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ struct matjson::Serialize<Settings> {
3434
assign(value["button_y"], s.buttonPos.y);
3535
assign(value["button_editor"], s.buttonInEditor);
3636
assign(value["button_game"], s.buttonInGame);
37-
GEODE_DESKTOP(assign(value["button_enabled"], s.buttonEnabled);)
37+
assign(value["button_enabled"], s.buttonEnabled);
3838
assign(value["tree_drag_reorder"], s.treeDragReorder);
3939

4040
return Ok(s);
@@ -57,7 +57,7 @@ struct matjson::Serialize<Settings> {
5757
{ "button_y", settings.buttonPos.y },
5858
{ "button_editor", settings.buttonInEditor },
5959
{ "button_game", settings.buttonInGame },
60-
GEODE_DESKTOP({ "button_enabled", settings.buttonEnabled },)
60+
{ "button_enabled", settings.buttonEnabled },
6161
{ "tree_drag_reorder", settings.treeDragReorder }
6262
});
6363
}
@@ -139,6 +139,14 @@ void DevTools::removeDragButton() {
139139
}
140140
}
141141

142+
bool DevTools::isButtonEnabled() {
143+
#ifdef GEODE_IS_MOBILE
144+
return true;
145+
#else
146+
return m_settings.buttonEnabled;
147+
#endif
148+
}
149+
142150
// Scroll when dragging empty space
143151
void mobileScrollBehavior() {
144152
auto* ctx = ImGui::GetCurrentContext();

src/DevTools.hpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ struct Settings {
3434
CCPoint buttonPos = {50, 50};
3535
bool buttonInEditor = false;
3636
bool buttonInGame = false;
37-
GEODE_DESKTOP(bool buttonEnabled = false;)
37+
bool buttonEnabled = false;
3838
bool treeDragReorder = false;
3939
};
4040

@@ -126,6 +126,7 @@ class DevTools {
126126
DragButton* getDragButton();
127127
void setupDragButton();
128128
void removeDragButton();
129+
bool isButtonEnabled();
129130

130131
void sceneChanged();
131132

src/main.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class $modify(CCKeyboardDispatcher) {
3636
#include <Geode/loader/GameEvent.hpp>
3737
$execute {
3838
new EventListener<GameEventFilter>(+[](GameEvent*) {
39-
GEODE_DESKTOP(if (DevTools::get()->getSettings().buttonEnabled)) DevTools::get()->setupDragButton();
39+
if (DevTools::get()->isButtonEnabled()) DevTools::get()->setupDragButton();
4040
}, GameEventFilter(GameEventType::Loaded));
4141
}
4242

src/pages/Settings.cpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -170,8 +170,8 @@ void DevTools::drawSettings() {
170170
"Shows the mobile button."
171171
);
172172
}
173-
if (m_settings.buttonEnabled) {
174173
#endif
174+
if (isButtonEnabled()) {
175175
ImGui::Checkbox("Button In Editor", &m_settings.buttonInEditor);
176176
if (ImGui::IsItemHovered()) {
177177
ImGui::SetTooltip(
@@ -184,9 +184,7 @@ void DevTools::drawSettings() {
184184
"Shows the mobile button in levels."
185185
);
186186
}
187-
#ifdef GEODE_IS_DESKTOP
188187
}
189-
#endif
190188

191189
#if 0
192190
static Ref<CCSet> PAUSED_TARGETS = nullptr;

0 commit comments

Comments
 (0)