Skip to content

Commit f16315b

Browse files
Merge pull request #2 from Kinin-Code-Offical/copilot/fix-eslint-errors-warnings
Fix ESLint errors: remove setState-in-effect and unused parameters
2 parents a74b079 + 177d3e2 commit f16315b

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

src/components/HomeClient.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,7 @@ export default function HomeClient({ content }: HomeClientProps) {
424424
);
425425
const [dockKeysVisible, setDockKeysVisible] = useState(true);
426426
const dockKeysVisibleRef = useRef(true);
427+
const [virtualKeysOpen, setVirtualKeysOpen] = useState(false);
427428
const scrollProgressRef = useSmoothScrollProgress(heroRef, (value) => {
428429
if (!shellRef.current) {
429430
return;
@@ -462,6 +463,10 @@ export default function HomeClient({ content }: HomeClientProps) {
462463
if (dockKeysVisibleRef.current !== nextDockKeysVisible) {
463464
dockKeysVisibleRef.current = nextDockKeysVisible;
464465
setDockKeysVisible(nextDockKeysVisible);
466+
// Close virtual keys when dock becomes hidden
467+
if (!nextDockKeysVisible) {
468+
setVirtualKeysOpen(false);
469+
}
465470
}
466471
});
467472
const isMobile = useMediaQuery("(max-width: 900px)");
@@ -501,7 +506,6 @@ export default function HomeClient({ content }: HomeClientProps) {
501506
shift: false,
502507
alt: false,
503508
});
504-
const [virtualKeysOpen, setVirtualKeysOpen] = useState(false);
505509
const mobileModifiersRef = useRef(mobileModifiers);
506510
const handleSceneReady = useCallback(() => {
507511
setSceneReady(true);
@@ -656,12 +660,6 @@ export default function HomeClient({ content }: HomeClientProps) {
656660
mobileModifiersRef.current = mobileModifiers;
657661
}, [mobileModifiers]);
658662

659-
useEffect(() => {
660-
if (!dockKeysVisible && virtualKeysOpen) {
661-
setVirtualKeysOpen(false);
662-
}
663-
}, [dockKeysVisible, virtualKeysOpen]);
664-
665663
useEffect(() => {
666664
screenAspectRef.current = screenAspect;
667665
}, [screenAspect]);

src/components/hero/HeroScene.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,6 @@ function ComputerModel({
292292
onScreenMeshAction,
293293
onCameraRig,
294294
onContentReady,
295-
isMobile,
296295
usePhoneRig,
297296
shadowsEnabled,
298297
allowTerminalTexture,
@@ -307,7 +306,6 @@ function ComputerModel({
307306
onScreenMeshAction?: (mesh: Mesh | null) => void;
308307
onCameraRig?: (rig: CameraRig) => void;
309308
onContentReady?: () => void;
310-
isMobile: boolean;
311309
usePhoneRig: boolean;
312310
shadowsEnabled: boolean;
313311
allowTerminalTexture: boolean;
@@ -788,6 +786,7 @@ function ComputerModel({
788786
scene,
789787
setPlaneColor,
790788
usePhoneRig,
789+
shadowsEnabled,
791790
]);
792791

793792
useEffect(() => {
@@ -1113,7 +1112,6 @@ function SceneContent({
11131112
scrollProgressRef,
11141113
noteTexts,
11151114
onDebugAction,
1116-
onFocusAction,
11171115
onScreenAspectAction,
11181116
onReadyAction,
11191117
interactionActive,
@@ -1627,7 +1625,6 @@ function SceneContent({
16271625
onScreenMeshAction={handleScreenMesh}
16281626
onCameraRig={handleCameraRig}
16291627
onContentReady={handleContentReady}
1630-
isMobile={isMobile}
16311628
usePhoneRig={usePhoneRig}
16321629
shadowsEnabled={shadowsEnabled}
16331630
allowTerminalTexture={true}

0 commit comments

Comments
 (0)