RobotStudio: breadboard scaffold#199
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @Kinin-Code-Offical, your pull request is larger than the review limit of 150000 diff characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0c6ecee0d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| assets = [(glb_path, f"assets/{glb_path.name}")] | ||
| for dep in collect_model_dependencies(glb_path): | ||
| assets.append((dep, f"assets/{dep.name}")) |
There was a problem hiding this comment.
This packs every dependency as assets/{dep.name}, which flattens any subdirectory structure. If a glTF/GLB references external files like textures/foo.png or buffers/mesh.bin, the model JSON will still look for those relative paths, but the package will only contain assets/foo.png or assets/mesh.bin, so textures/buffers won’t resolve at runtime. This only shows up for models whose URIs include path segments, so preserving the relative path (or rewriting URIs) is needed to avoid missing assets.
Useful? React with 👍 / 👎.
1 participant
Follow-up after #198: adds BreadboardSpec to AssemblySpec and wires minimal RobotStudio UI fields + runtime stub component so breadboards can be instantiated from package data.