refactor: reduce runtime dependencies (#351)

* refactor: reduce runtime dependencies

* fix: enable wasm feature for wasm-pack targets

* fix: keep null count in histogram bucket estimate

Author: KKould

Cargo.lock

@@ -37,6 +37,11 @@ lmdb    = ["dep:lmdb", "dep:lmdb-sys"]
 pprof   = ["pprof/criterion", "pprof/flamegraph"]
 python  = ["parser", "dep:pyo3"]
 shell   = ["parser", "dep:comfy-table", "dep:rustyline"]
+wasm    = [
+    "dep:js-sys",
+    "dep:wasm-bindgen",
+    "parser",
+]
 
 [[bench]]
 name    = "query_bench"
@@ -45,17 +50,10 @@ harness = false
 required-features = ["pprof"]
 
 [dependencies]
-ahash                 = { version = "0.8" }
 bumpalo               = { version = "3", default-features = false, features = ["collections"] }
-byteorder             = { version = "1" }
-fixedbitset           = { version = "0.4" }
-itertools             = { version = "0.12" }
 ordered-float         = { version = "4" }
 paste                 = { version = "1" }
-recursive             = { version = "0.1" }
 kite_sql_serde_macros = { version = "0.2.1", path = "kite_sql_serde_macros" }
-siphasher             = { version = "1" }
-ulid                  = { version = "1" }
 
 # Optional dependencies for features
 comfy-table           = { version = "7", default-features = false, optional = true }
@@ -84,16 +82,8 @@ rocksdb = { version = "0.23", optional = true, default-features = false, feature
 rustyline = { version = "14", default-features = false, optional = true }
 
 [target.'cfg(target_arch = "wasm32")'.dependencies]
-wasm-bindgen        = { version = "0.2.106" }
-web-sys             = { version = "0.3.83", features = [
-    "Storage",
-    "Window",
-] }
-base64              = { version = "0.21" }
-getrandom           = { version = "0.2", features = ["js"] }
-getrandom_03        = { package = "getrandom", version = "0.3", features = ["wasm_js"] }
-js-sys              = { version = "0.3.83" }
-once_cell           = { version = "1" }
+wasm-bindgen        = { version = "0.2.106", optional = true }
+js-sys              = { version = "0.3.83", optional = true }
 
 [target.'cfg(target_arch = "wasm32")'.dev-dependencies]
 wasm-bindgen-test = "0.3.56"

Cargo.toml

@@ -30,11 +30,11 @@ build:
 
 ## Build the WebAssembly package (artifact goes to ./pkg).
 wasm-build:
-	$(WASM_PACK) build --release --target nodejs
+	$(WASM_PACK) build --release --target nodejs -- --features wasm
 
 ## Execute wasm-bindgen tests under Node.js (wasm32 target).
 test-wasm:
-	$(WASM_PACK) test --node -- --package kite_sql --lib
+	$(WASM_PACK) test --node -- --features wasm --package kite_sql --lib
 
 ## Run the sqllogictest harness against the configured .slt suite.
 test-slt:

Makefile

@@ -12,8 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use ahash::RandomState;
-use itertools::Itertools;
 use std::collections::HashSet;
 
 use super::{Binder, QueryBindStep};
@@ -266,7 +264,7 @@ impl<T: Transaction, A: AsRef<[(&'static str, DataValue)]>> Binder<'_, '_, T, A>
                 group_raw_exprs.push(expr);
             }
         }
-        let mut group_raw_set: HashSet<&ScalarExpression, RandomState> =
+        let mut group_raw_set: HashSet<&ScalarExpression> =
             HashSet::from_iter(group_raw_exprs.iter().copied());
 
         for expr in select_items {
@@ -275,7 +273,7 @@ impl<T: Transaction, A: AsRef<[(&'static str, DataValue)]>> Binder<'_, '_, T, A>
             }
             group_raw_set.remove(expr);
 
-            if !group_raw_exprs.iter().contains(&expr) {
+            if !group_raw_exprs.contains(&expr) {
                 return Err(DatabaseError::AggMiss(format!(
                     "`{expr}` must appear in the GROUP BY clause or be used in an aggregate function"
                 )));

src/binder/aggregate.rs

@@ -22,7 +22,6 @@ use crate::planner::operator::Operator;
 use crate::planner::{Childrens, LogicalPlan};
 use crate::storage::Transaction;
 use crate::types::value::DataValue;
-use ulid::Ulid;
 
 impl<T: Transaction, A: AsRef<[(&'static str, DataValue)]>> Binder<'_, '_, T, A> {
     pub(crate) fn bind_create_view(
@@ -52,7 +51,7 @@ impl<T: Transaction, A: AsRef<[(&'static str, DataValue)]>> Binder<'_, '_, T, A>
                     )
                 };
                 let mut column = ColumnCatalog::new(output_name, nullable, desc);
-                column.set_ref_table(view_name.clone(), Ulid::new(), true);
+                column.set_ref_table(view_name.clone(), 0, true);
                 let output_column = arena.alloc_column(column);
 
                 exprs.push(ScalarExpression::Alias {