Core: Fix some accidental copies during iteration

Author: zach2good

src/map/ai/helpers/targetfind.cpp

@@ -390,11 +390,13 @@ void CTargetFind::addAllInRange(CBattleEntity* PTarget, float radius, ALLEGIANCE
         if (PTarget->objtype == TYPE_PC)
         {
             CCharEntity* PChar = static_cast<CCharEntity*>(PTarget);
-            for (auto& spawnList : { PChar->SpawnPCList, PChar->SpawnPETList })
+            for (const auto* spawnList : { &PChar->SpawnPCList, &PChar->SpawnPETList })
             {
-                FOR_EACH_PAIR_CAST_SECOND(CBattleEntity*, PBattleEntity, spawnList)
+                FOR_EACH_PAIR_CAST_SECOND(CBattleEntity*, PBattleEntity, *spawnList)
                 {
-                    if (PBattleEntity && isWithinArea(&(PBattleEntity->loc.p)) && !PBattleEntity->isDead() &&
+                    if (PBattleEntity &&
+                        isWithinArea(&(PBattleEntity->loc.p)) &&
+                        !PBattleEntity->isDead() &&
                         PBattleEntity->allegiance == ALLEGIANCE_TYPE::PLAYER)
                     {
                         m_targets.emplace_back(PBattleEntity);

src/map/ai/states/petskill_state.cpp

@@ -73,11 +73,11 @@ CPetSkillState::CPetSkillState(CPetEntity* PEntity, uint16 targid, uint16 wsid)
             .actionid   = static_cast<uint32_t>(FourCC::SkillUse),
             .targets    = {
                 {
-                       .actorId = PTarget->id,
-                       .results = {
+                    .actorId = PTarget->id,
+                    .results = {
                         {
-                               .param     = m_PSkill->getMobSkillID() > 0 ? m_PSkill->getMobSkillID() : m_PSkill->getID(),
-                               .messageID = m_PSkill->getMobSkillID() > 0 ? MsgBasic::ReadiesWeaponskill : MsgBasic::ReadiesSkill,
+                            .param     = m_PSkill->getMobSkillID() > 0 ? m_PSkill->getMobSkillID() : m_PSkill->getID(),
+                            .messageID = m_PSkill->getMobSkillID() > 0 ? MsgBasic::ReadiesWeaponskill : MsgBasic::ReadiesSkill,
                         },
                     },
                 },

src/map/zone.cpp

@@ -771,7 +771,7 @@ bool CZone::CheckMobsPathedBack()
     bool allMobsHomeAndHealed = true;
     if (m_zoneEntities && m_zoneEntities->GetMobList().size() > 0)
     {
-        EntityList_t mobListMap = m_zoneEntities->GetMobList();
+        const auto& mobListMap = m_zoneEntities->GetMobList();
         for (const auto& pair : mobListMap)
         {
             CMobEntity* mob = dynamic_cast<CMobEntity*>(pair.second);