Commit 35e3a15
fix: use OsString for EnvGuard and add remove() constructor
Addresses PR review feedback:
- Store previous env var as OsString (via env::var_os) to correctly
handle non-UTF-8 values instead of silently dropping them.
- Add EnvGuard::remove() for tests that need to ensure a variable
is unset, so test_envsubst_missing also gets proper cleanup.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>1 parent b3a030c commit 35e3a15
1 file changed
Lines changed: 14 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| 80 | + | |
| 81 | + | |
80 | 82 | | |
81 | 83 | | |
82 | | - | |
| 84 | + | |
83 | 85 | | |
84 | 86 | | |
85 | 87 | | |
86 | 88 | | |
87 | | - | |
| 89 | + | |
88 | 90 | | |
89 | 91 | | |
90 | 92 | | |
91 | 93 | | |
92 | 94 | | |
93 | 95 | | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
94 | 105 | | |
95 | 106 | | |
96 | 107 | | |
| |||
110 | 121 | | |
111 | 122 | | |
112 | 123 | | |
113 | | - | |
| 124 | + | |
114 | 125 | | |
115 | 126 | | |
116 | 127 | | |
| |||
0 commit comments