refactor: remove placeholder seed_sets from test specs and move inline seed specs to files

mikkeldamsgaard · mikkeldamsgaard · commit 7cf446ee508a · 2026-02-25T09:00:28.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,11 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+- Removed placeholder `seed_sets` from create-if-missing integration test YAML files; phases with only `create_if_missing` no longer need empty seed sets (`seed_sets` was already optional via `#[serde(default)]`)
+
 ### Added
 - Integration tests with docker-compose for end-to-end testing against real Postgres 16, MySQL 8.0, and nginx services (`tests/integration_test.rs`): wait-for TCP/HTTP/timeout/multiple targets, render template, fetch HTTP, exec command, seed PostgreSQL and MySQL with cross-table reference verification, create database/schema, idempotency, and reset mode
 - Additional create-if-missing integration tests: 2 PostgreSQL and 2 MySQL tests using known non-existing database names (`initium_noexist_alpha`, `initium_noexist_beta`) to verify database creation, existence checks, and idempotent re-runs
 - `tests/docker-compose.yml` with Postgres, MySQL, and HTTP health-check server definitions
-- `tests/fixtures/` with seed spec files and template for integration tests
+- `tests/input/` with seed spec files and template for integration tests
 - Separate GitHub Actions workflow (`.github/workflows/integration.yml`) for integration tests with service containers
 - Helm chart unit tests using helm-unittest plugin (`charts/initium/tests/deployment_test.yaml`) covering deployment rendering, securityContext enforcement, disabled sampleDeployment, multiple initContainers, extraVolumes/extraVolumeMounts, image configuration, workdir mount, and labels
 - `helm unittest` step added to CI helm-lint job with automatic plugin installation
diff --git a/tests/input/create-db-mysql.yaml b/tests/input/create-db-mysql.yaml
@@ -0,0 +1,15 @@
+database:
+  driver: mysql
+  url_env: MYSQL_URL
+  tracking_table: initium_seed
+
+phases:
+  - name: create_db
+    order: 1
+    database: initium_created_db
+    create_if_missing: true
+    seed_sets:
+      - name: placeholder
+        tables:
+          - table: products
+            rows: []
diff --git a/tests/input/create-db-postgres.yaml b/tests/input/create-db-postgres.yaml
@@ -0,0 +1,15 @@
+database:
+  driver: postgres
+  url_env: POSTGRES_URL
+  tracking_table: initium_seed
+
+phases:
+  - name: create_db
+    order: 1
+    database: initium_created_db
+    create_if_missing: true
+    seed_sets:
+      - name: placeholder
+        tables:
+          - table: departments
+            rows: []
diff --git a/tests/input/create-nonexistent-db-alpha-mysql.yaml b/tests/input/create-nonexistent-db-alpha-mysql.yaml
@@ -0,0 +1,10 @@
+database:
+  driver: mysql
+  url_env: MYSQL_URL
+  tracking_table: initium_seed
+
+phases:
+  - name: create_alpha
+    order: 1
+    database: initium_noexist_alpha
+    create_if_missing: true
diff --git a/tests/input/create-nonexistent-db-alpha-postgres.yaml b/tests/input/create-nonexistent-db-alpha-postgres.yaml
@@ -0,0 +1,10 @@
+database:
+  driver: postgres
+  url_env: POSTGRES_URL
+  tracking_table: initium_seed
+
+phases:
+  - name: create_alpha
+    order: 1
+    database: initium_noexist_alpha
+    create_if_missing: true
diff --git a/tests/input/create-nonexistent-db-beta-mysql.yaml b/tests/input/create-nonexistent-db-beta-mysql.yaml
@@ -0,0 +1,10 @@
+database:
+  driver: mysql
+  url_env: MYSQL_URL
+  tracking_table: initium_seed
+
+phases:
+  - name: create_beta
+    order: 1
+    database: initium_noexist_beta
+    create_if_missing: true
diff --git a/tests/input/create-nonexistent-db-beta-postgres.yaml b/tests/input/create-nonexistent-db-beta-postgres.yaml
@@ -0,0 +1,10 @@
+database:
+  driver: postgres
+  url_env: POSTGRES_URL
+  tracking_table: initium_seed
+
+phases:
+  - name: create_beta
+    order: 1
+    database: initium_noexist_beta
+    create_if_missing: true
diff --git a/tests/input/create-schema-postgres.yaml b/tests/input/create-schema-postgres.yaml
@@ -0,0 +1,15 @@
+database:
+  driver: postgres
+  url_env: POSTGRES_URL
+  tracking_table: initium_seed
+
+phases:
+  - name: create_schema
+    order: 1
+    schema: test_analytics
+    create_if_missing: true
+    seed_sets:
+      - name: placeholder
+        tables:
+          - table: departments
+            rows: []
diff --git a/tests/input/seed-mysql.yaml b/tests/input/seed-mysql.yaml
diff --git a/tests/input/seed-postgres.yaml b/tests/input/seed-postgres.yaml
diff --git a/tests/input/template.conf.tmpl b/tests/input/template.conf.tmpl
diff --git a/tests/integration_test.rs b/tests/integration_test.rs
@@ -18,9 +18,9 @@ fn integration_enabled() -> bool {
     std::env::var("INTEGRATION").map_or(false, |v| v == "1")
 }
 
-fn fixtures_dir() -> String {
+fn input_dir() -> String {
     let manifest = env!("CARGO_MANIFEST_DIR");
-    format!("{}/tests/fixtures", manifest)
+    format!("{}/tests/input", manifest)
 }
 
 const PG_URL: &str = "postgres://initium:initium@localhost:15432/initium_test";
@@ -215,7 +215,7 @@ fn test_render_template() {
         return;
     }
     let workdir = tempfile::TempDir::new().expect("failed to create tempdir");
-    let template = format!("{}/template.conf.tmpl", fixtures_dir());
+    let template = format!("{}/template.conf.tmpl", input_dir());
 
     let out = Command::new(initium_bin())
         .args([
@@ -352,7 +352,7 @@ fn test_seed_postgres() {
         )
         .expect("failed to create postgres tables");
 
-    let spec = format!("{}/seed-postgres.yaml", fixtures_dir());
+    let spec = format!("{}/seed-postgres.yaml", input_dir());
     let out = Command::new(initium_bin())
         .args(["seed", "--spec", &spec])
         .env("POSTGRES_URL", PG_URL)
@@ -469,7 +469,7 @@ fn test_seed_mysql() {
     )
     .unwrap();
 
-    let spec = format!("{}/seed-mysql.yaml", fixtures_dir());
+    let spec = format!("{}/seed-mysql.yaml", input_dir());
     let out = Command::new(initium_bin())
         .args(["seed", "--spec", &spec])
         .env("MYSQL_URL", MYSQL_URL_STR)
@@ -549,16 +549,9 @@ fn test_seed_postgres_create_database() {
     let mut client = pg_client();
     let _ = client.batch_execute("DROP DATABASE IF EXISTS initium_created_db");
 
-    let workdir = tempfile::TempDir::new().expect("failed to create tempdir");
-    let spec_path = workdir.path().join("create-db-seed.yaml");
-    std::fs::write(
-        &spec_path,
-        "database:\n  driver: postgres\n  url_env: POSTGRES_URL\n  tracking_table: initium_seed\n\nphases:\n  - name: create_db\n    order: 1\n    database: initium_created_db\n    create_if_missing: true\n    seed_sets:\n      - name: placeholder\n        tables:\n          - table: departments\n            rows: []\n",
-    )
-    .expect("failed to write spec");
-
+    let spec = format!("{}/create-db-postgres.yaml", input_dir());
     let out = Command::new(initium_bin())
-        .args(["seed", "--spec", spec_path.to_str().unwrap()])
+        .args(["seed", "--spec", &spec])
         .env("POSTGRES_URL", PG_URL)
         .output()
         .expect("failed to run seed");
@@ -585,7 +578,7 @@ fn test_seed_postgres_create_database() {
 
     // Idempotent re-run
     let out = Command::new(initium_bin())
-        .args(["seed", "--spec", spec_path.to_str().unwrap()])
+        .args(["seed", "--spec", &spec])
         .env("POSTGRES_URL", PG_URL)
         .output()
         .expect("failed to re-run seed");
@@ -609,16 +602,9 @@ fn test_seed_postgres_create_schema() {
     let mut client = pg_client();
     let _ = client.batch_execute("DROP SCHEMA IF EXISTS test_analytics CASCADE");
 
-    let workdir = tempfile::TempDir::new().expect("failed to create tempdir");
-    let spec_path = workdir.path().join("create-schema-seed.yaml");
-    std::fs::write(
-        &spec_path,
-        "database:\n  driver: postgres\n  url_env: POSTGRES_URL\n  tracking_table: initium_seed\n\nphases:\n  - name: create_schema\n    order: 1\n    schema: test_analytics\n    create_if_missing: true\n    seed_sets:\n      - name: placeholder\n        tables:\n          - table: departments\n            rows: []\n",
-    )
-    .expect("failed to write spec");
-
+    let spec = format!("{}/create-schema-postgres.yaml", input_dir());
     let out = Command::new(initium_bin())
-        .args(["seed", "--spec", spec_path.to_str().unwrap()])
+        .args(["seed", "--spec", &spec])
         .env("POSTGRES_URL", PG_URL)
         .output()
         .expect("failed to run seed");
@@ -659,16 +645,9 @@ fn test_seed_mysql_create_database() {
     let mut conn = mysql_root_conn();
     let _ = conn.query_drop("DROP DATABASE IF EXISTS initium_created_db");
 
-    let workdir = tempfile::TempDir::new().expect("failed to create tempdir");
-    let spec_path = workdir.path().join("create-db-seed.yaml");
-    std::fs::write(
-        &spec_path,
-        "database:\n  driver: mysql\n  url_env: MYSQL_URL\n  tracking_table: initium_seed\n\nphases:\n  - name: create_db\n    order: 1\n    database: initium_created_db\n    create_if_missing: true\n    seed_sets:\n      - name: placeholder\n        tables:\n          - table: products\n            rows: []\n",
-    )
-    .expect("failed to write spec");
-
+    let spec = format!("{}/create-db-mysql.yaml", input_dir());
     let out = Command::new(initium_bin())
-        .args(["seed", "--spec", spec_path.to_str().unwrap()])
+        .args(["seed", "--spec", &spec])
         .env("MYSQL_URL", MYSQL_ROOT_URL_STR)
         .output()
         .expect("failed to run seed");
@@ -689,7 +668,7 @@ fn test_seed_mysql_create_database() {
 
     // Idempotent re-run
     let out = Command::new(initium_bin())
-        .args(["seed", "--spec", spec_path.to_str().unwrap()])
+        .args(["seed", "--spec", &spec])
         .env("MYSQL_URL", MYSQL_ROOT_URL_STR)
         .output()
         .expect("failed to re-run seed");
@@ -723,16 +702,9 @@ fn test_seed_postgres_create_nonexistent_db_alpha() {
         .get(0);
     assert_eq!(count, 0, "database should not exist before test");
 
-    let workdir = tempfile::TempDir::new().expect("failed to create tempdir");
-    let spec_path = workdir.path().join("create-db-alpha.yaml");
-    std::fs::write(
-        &spec_path,
-        "database:\n  driver: postgres\n  url_env: POSTGRES_URL\n  tracking_table: initium_seed\n\nphases:\n  - name: create_alpha\n    order: 1\n    database: initium_noexist_alpha\n    create_if_missing: true\n    seed_sets:\n      - name: placeholder\n        tables:\n          - table: departments\n            rows: []\n",
-    )
-    .expect("failed to write spec");
-
+    let spec = format!("{}/create-nonexistent-db-alpha-postgres.yaml", input_dir());
     let out = Command::new(initium_bin())
-        .args(["seed", "--spec", spec_path.to_str().unwrap()])
+        .args(["seed", "--spec", &spec])
         .env("POSTGRES_URL", PG_URL)
         .output()
         .expect("failed to run seed");
@@ -783,16 +755,9 @@ fn test_seed_postgres_create_nonexistent_db_beta() {
         .get(0);
     assert_eq!(count, 0, "database should not exist before test");
 
-    let workdir = tempfile::TempDir::new().expect("failed to create tempdir");
-    let spec_path = workdir.path().join("create-db-beta.yaml");
-    std::fs::write(
-        &spec_path,
-        "database:\n  driver: postgres\n  url_env: POSTGRES_URL\n  tracking_table: initium_seed\n\nphases:\n  - name: create_beta\n    order: 1\n    database: initium_noexist_beta\n    create_if_missing: true\n    seed_sets:\n      - name: placeholder\n        tables:\n          - table: departments\n            rows: []\n",
-    )
-    .expect("failed to write spec");
-
+    let spec = format!("{}/create-nonexistent-db-beta-postgres.yaml", input_dir());
     let out = Command::new(initium_bin())
-        .args(["seed", "--spec", spec_path.to_str().unwrap()])
+        .args(["seed", "--spec", &spec])
         .env("POSTGRES_URL", PG_URL)
         .output()
         .expect("failed to run seed");
@@ -820,7 +785,7 @@ fn test_seed_postgres_create_nonexistent_db_beta() {
 
     // Re-run to verify idempotency — should not fail
     let out = Command::new(initium_bin())
-        .args(["seed", "--spec", spec_path.to_str().unwrap()])
+        .args(["seed", "--spec", &spec])
         .env("POSTGRES_URL", PG_URL)
         .output()
         .expect("failed to re-run seed");
@@ -854,16 +819,9 @@ fn test_seed_mysql_create_nonexistent_db_alpha() {
         .unwrap();
     assert_eq!(count, Some(0), "database should not exist before test");
 
-    let workdir = tempfile::TempDir::new().expect("failed to create tempdir");
-    let spec_path = workdir.path().join("create-db-alpha.yaml");
-    std::fs::write(
-        &spec_path,
-        "database:\n  driver: mysql\n  url_env: MYSQL_URL\n  tracking_table: initium_seed\n\nphases:\n  - name: create_alpha\n    order: 1\n    database: initium_noexist_alpha\n    create_if_missing: true\n    seed_sets:\n      - name: placeholder\n        tables:\n          - table: products\n            rows: []\n",
-    )
-    .expect("failed to write spec");
-
+    let spec = format!("{}/create-nonexistent-db-alpha-mysql.yaml", input_dir());
     let out = Command::new(initium_bin())
-        .args(["seed", "--spec", spec_path.to_str().unwrap()])
+        .args(["seed", "--spec", &spec])
         .env("MYSQL_URL", MYSQL_ROOT_URL_STR)
         .output()
         .expect("failed to run seed");
@@ -908,16 +866,9 @@ fn test_seed_mysql_create_nonexistent_db_beta() {
         .unwrap();
     assert_eq!(count, Some(0), "database should not exist before test");
 
-    let workdir = tempfile::TempDir::new().expect("failed to create tempdir");
-    let spec_path = workdir.path().join("create-db-beta.yaml");
-    std::fs::write(
-        &spec_path,
-        "database:\n  driver: mysql\n  url_env: MYSQL_URL\n  tracking_table: initium_seed\n\nphases:\n  - name: create_beta\n    order: 1\n    database: initium_noexist_beta\n    create_if_missing: true\n    seed_sets:\n      - name: placeholder\n        tables:\n          - table: products\n            rows: []\n",
-    )
-    .expect("failed to write spec");
-
+    let spec = format!("{}/create-nonexistent-db-beta-mysql.yaml", input_dir());
     let out = Command::new(initium_bin())
-        .args(["seed", "--spec", spec_path.to_str().unwrap()])
+        .args(["seed", "--spec", &spec])
         .env("MYSQL_URL", MYSQL_ROOT_URL_STR)
         .output()
         .expect("failed to run seed");
@@ -939,7 +890,7 @@ fn test_seed_mysql_create_nonexistent_db_beta() {
 
     // Re-run to verify idempotency — should not fail
     let out = Command::new(initium_bin())
-        .args(["seed", "--spec", spec_path.to_str().unwrap()])
+        .args(["seed", "--spec", &spec])
         .env("MYSQL_URL", MYSQL_ROOT_URL_STR)
         .output()
         .expect("failed to re-run seed");
