Add Zoodle inset appearance and service-backed tools#12287
Open
franknoirot wants to merge 5 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
045ee32 to
e47dc64
Compare
f3c9605 to
67f5a26
Compare
4a85f8d to
1c87cc4
Compare
67f5a26 to
bb8725a
Compare
1c87cc4 to
948b391
Compare
bb8725a to
c52313c
Compare
andrewvarga
reviewed
Jul 2, 2026
Comment on lines
+287
to
288
| const [isZoodleActive, setIsZoodleActive] = useState(false) | ||
| const zoodleRuntimeExtensionActive = useRef(false) |
Contributor
There was a problem hiding this comment.
These 2 states look very similar, could they be unified? I understand a ref doesn't update React and the state may be lagging by an update cycle..if it's unavoidable it may be worth adding a comment for why there is both?
andrewvarga
reviewed
Jul 2, 2026
andrewvarga
left a comment
Contributor
There was a problem hiding this comment.
Nice! A small UX NIT:
There is an animation for the green inset, which is sometimes fluid, sometimes it skips (in your video it jumps without an animation). Not sure if that's intentional but if it fades in, it should probably also fade out when you deactivate it to be consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
equipToolAPI.Stacked on #12284 (
franknoirot/adhoc/zoodle-engine-scene-runtime-extension).Demo
Screenshare.-.2026-07-01.1_56_04.PM-compressed.mp4
Testing
npx biome check --formatter-enabled=true --linter-enabled=false --organize-imports-enabled=true --files-ignore-unknown=true src/components/ViewportAnnotationOverlay.tsx src/components/MlEphantConversation.spec.tsx src/registry/contracts/zoodle.ts src/registry/extensions/engineScene/zoodleRuntimeExtension.tsx src/registry/extensions/engineScene/zoodleRuntimeExtension.spec.tsnpx vitest run --mode=development src/registry/extensions/engineScene/zoodleRuntimeExtension.spec.ts src/registry/extensions/engineScene/index.spec.ts src/components/MlEphantConversation.spec.tsxnpm run tsc -- --noEmit